Patrick.Sy/spring-petclinic
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-petclinic.git synced 2025-04-24 19:32:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix pet update functionality
Some checks failed
Java CI with Gradle / build (17) (push) Has been cancelled
Details
Java CI with Maven / build (17) (push) Has been cancelled
Details

Browse source 
- Fixed issue where editing a pet's type or name wasn't persisting
- Updated processUpdateForm to modify existing pet instead of
  adding new one
- Added proper handling of existing pet update

Fixes #1752
This commit is contained in:
VishantOwO 2025-01-01 03:52:27 +05:30 committed by Dave Syer
parent 6328d2c9dc
commit 2aa53f929d
1 changed files with 21 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
src/main/java/org/springframework/samples/petclinic/owner/PetController.java
View file

@ -129,7 +129,7 @@ class PetController {
String petName = pet.getName(); String petName = pet.getName();
// checking if the pet name already exist for the owner // checking if the pet name already exists for the owner
if (StringUtils.hasText(petName)) { if (StringUtils.hasText(petName)) {
Pet existingPet = owner.getPet(petName, false); Pet existingPet = owner.getPet(petName, false);
if (existingPet != null && !existingPet.getId().equals(pet.getId())) { if (existingPet != null && !existingPet.getId().equals(pet.getId())) {
@ -146,10 +146,28 @@ class PetController {
return VIEWS_PETS_CREATE_OR_UPDATE_FORM; return VIEWS_PETS_CREATE_OR_UPDATE_FORM;
} }
owner.addPet(pet); updatePetDetails(owner, pet);
this.owners.save(owner);
redirectAttributes.addFlashAttribute("message", "Pet details has been edited"); redirectAttributes.addFlashAttribute("message", "Pet details has been edited");
return "redirect:/owners/{ownerId}"; return "redirect:/owners/{ownerId}";
} }
/**
* Updates the pet details if it exists or adds a new pet to the owner.
* @param owner The owner of the pet
* @param pet The pet with updated details
*/
private void updatePetDetails(Owner owner, Pet pet) {
Pet existingPet = owner.getPet(pet.getId());
if (existingPet != null) {
// Update existing pet's properties
existingPet.setName(pet.getName());
existingPet.setBirthDate(pet.getBirthDate());
existingPet.setType(pet.getType());
}
else {
owner.addPet(pet);
}
this.owners.save(owner);
}
} }