Patrick.Sy/spring-petclinic
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-petclinic.git synced 2025-07-22 15:55:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

[FIX] As per the requested changes, removed the private method for establishing the current date and made it part of the test setup. Also, made the testSetAndGetOwner more comprehensive by checking that each of the attributes particular to the owner were set and retrieved appropriately.

Browse source
This commit is contained in:
Jad Malek 2018-02-24 23:06:43 -05:00
parent b6d3dd1c11
commit 2b1ea2a3d6
1 changed files with 17 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
src/test/java/org/springframework/samples/petclinic/owner/PetTests.java
View file

@ -16,24 +16,22 @@ public class PetTests {
private Pet pet;
private Date birthDate;
private void establishCurrentDateForTesting() {
@Before
public void testSetUp() {
//Initialization of pet
this.pet = new Pet();
PetType dog = new PetType();
dog.setId(9);
dog.setName("Duncan Jones");
//Initialization of birthDate
//Converting the current time to a local date and ultimately a date to be input into setBirthDate;
LocalDateTime timePoint = LocalDateTime.now();
LocalDate localDate = timePoint.toLocalDate();
birthDate = Date.from(localDate.atStartOfDay(ZoneId.systemDefault()).toInstant());
}
@Before
public void testSetUp() {
this.pet = new Pet();
PetType dog = new PetType();
dog.setId(9);
dog.setName("Duncan Jones");
}
@Test
public void testSetAndGetBirthDate() {
//Converting the current time to a local date and ultimately a date to be input into setBirthDate
this.establishCurrentDateForTesting();
pet.setBirthDate(this.birthDate);
Date resultOfGetDate = pet.getBirthDate();
assertEquals(this.birthDate, resultOfGetDate);
@ -54,9 +52,16 @@ public class PetTests {
public void testSetAndGetOwner() {
//Creating a new owner type to test the setters and getters for the pet's owner
Owner amandeepBhandal = new Owner();
amandeepBhandal.setAddress("Off-world Colony");
amandeepBhandal.setCity("Beirut");
amandeepBhandal.setTelephone("514-333-3333");
//Attach the newly created owner to the pet
pet.setOwner(amandeepBhandal);
Owner resultOfGetOwner = pet.getOwner();
assertEquals(amandeepBhandal.getAddress(), resultOfGetOwner.getAddress());
assertEquals(resultOfGetOwner.getAddress(), "Off-world Colony");
assertEquals(resultOfGetOwner.getCity(), "Beirut");
assertEquals(resultOfGetOwner.getTelephone(), "514-333-3333");
assertEquals(resultOfGetOwner.getPetsInternal().size(), 0);
}
@Test