diff --git a/src/main/java/org/springframework/samples/petclinic/model/Person.java b/src/main/java/org/springframework/samples/petclinic/model/Person.java index 7c3d81a84..9ded89c1b 100644 --- a/src/main/java/org/springframework/samples/petclinic/model/Person.java +++ b/src/main/java/org/springframework/samples/petclinic/model/Person.java @@ -28,11 +28,11 @@ import jakarta.validation.constraints.NotBlank; public class Person extends BaseEntity { @Column(name = "first_name") - @NotBlank + @NotBlank(message = "First Name cannot be blank") private String firstName; @Column(name = "last_name") - @NotBlank + @NotBlank(message = "Last Name cannot be blank") private String lastName; public String getFirstName() { diff --git a/src/main/java/org/springframework/samples/petclinic/owner/Owner.java b/src/main/java/org/springframework/samples/petclinic/owner/Owner.java index c7394689a..e5f2a7160 100644 --- a/src/main/java/org/springframework/samples/petclinic/owner/Owner.java +++ b/src/main/java/org/springframework/samples/petclinic/owner/Owner.java @@ -18,6 +18,7 @@ package org.springframework.samples.petclinic.owner; import java.util.ArrayList; import java.util.List; +import jakarta.validation.constraints.Pattern; import org.springframework.core.style.ToStringCreator; import org.springframework.samples.petclinic.model.Person; import org.springframework.util.Assert; @@ -47,16 +48,16 @@ import jakarta.validation.constraints.NotBlank; public class Owner extends Person { @Column(name = "address") - @NotBlank + @NotBlank(message = "Address cannot be blank") private String address; @Column(name = "city") - @NotBlank + @NotBlank(message = "City cannot be blank") private String city; @Column(name = "telephone") - @NotBlank - @Digits(fraction = 0, integer = 10) + @NotBlank(message = "Telephone cannot be blank") + @Pattern(regexp = "\\d{10}", message = "Telephone must be a 10-digit number") private String telephone; @OneToMany(cascade = CascadeType.ALL, fetch = FetchType.EAGER) diff --git a/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests.java b/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests.java index 9fcd5987a..d56f0da84 100644 --- a/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests.java +++ b/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests.java @@ -54,7 +54,7 @@ class ValidatorTests { assertThat(constraintViolations).hasSize(1); ConstraintViolation violation = constraintViolations.iterator().next(); assertThat(violation.getPropertyPath().toString()).isEqualTo("firstName"); - assertThat(violation.getMessage()).isEqualTo("must not be blank"); + assertThat(violation.getMessage()).isEqualTo("First Name cannot be blank"); } } diff --git a/src/test/java/org/springframework/samples/petclinic/owner/OwnerControllerTests.java b/src/test/java/org/springframework/samples/petclinic/owner/OwnerControllerTests.java index 78b812371..e1d85bea3 100644 --- a/src/test/java/org/springframework/samples/petclinic/owner/OwnerControllerTests.java +++ b/src/test/java/org/springframework/samples/petclinic/owner/OwnerControllerTests.java @@ -117,7 +117,7 @@ class OwnerControllerTests { .param("lastName", "Bloggs") .param("address", "123 Caramel Street") .param("city", "London") - .param("telephone", "01316761638")) + .param("telephone", "0123456789")) .andExpect(status().is3xxRedirection()); } @@ -188,7 +188,7 @@ class OwnerControllerTests { .param("lastName", "Bloggs") .param("address", "123 Caramel Street") .param("city", "London") - .param("telephone", "01616291589")) + .param("telephone", "0123456789")) .andExpect(status().is3xxRedirection()) .andExpect(view().name("redirect:/owners/{ownerId}")); }