removing JdbcTemplate so we use NamedParameterJdbcTemplate solely when possible

src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcOwnerRepositoryImpl.java

@@ -1,14 +1,15 @@
 package org.springframework.samples.petclinic.repository.jdbc;
 
 import java.util.Collection;
+import java.util.HashMap;
 import java.util.List;
+import java.util.Map;
 
 import javax.sql.DataSource;
 
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.dao.DataAccessException;
 import org.springframework.dao.EmptyResultDataAccessException;
-import org.springframework.jdbc.core.JdbcTemplate;
 import org.springframework.jdbc.core.namedparam.BeanPropertySqlParameterSource;
 import org.springframework.jdbc.core.namedparam.NamedParameterJdbcTemplate;
 import org.springframework.jdbc.core.simple.ParameterizedBeanPropertyRowMapper;
@@ -19,7 +20,6 @@ import org.springframework.samples.petclinic.Pet;
 import org.springframework.samples.petclinic.PetType;
 import org.springframework.samples.petclinic.Visit;
 import org.springframework.samples.petclinic.repository.OwnerRepository;
-import org.springframework.samples.petclinic.repository.PetRepository;
 import org.springframework.samples.petclinic.repository.VisitRepository;
 import org.springframework.samples.petclinic.util.EntityUtils;
 import org.springframework.stereotype.Service;
@@ -39,14 +39,8 @@ import org.springframework.transaction.annotation.Transactional;
 @Service
 public class JdbcOwnerRepositoryImpl implements OwnerRepository {
 
-	@Autowired
-	private PetRepository petRepository;
-	
-	@Autowired
 	private VisitRepository visitRepository;
 	
-	@Autowired
-	private JdbcTemplate jdbcTemplate;
 	
 	@Autowired
 	private NamedParameterJdbcTemplate namedParameterJdbcTemplate;
@@ -54,11 +48,16 @@ public class JdbcOwnerRepositoryImpl implements OwnerRepository {
 	private SimpleJdbcInsert insertOwner;
 
 	@Autowired
-	public void init(DataSource dataSource) {
+	public JdbcOwnerRepositoryImpl(DataSource dataSource, NamedParameterJdbcTemplate namedParameterJdbcTemplate, 
+				VisitRepository visitRepository) {
 
 		this.insertOwner = new SimpleJdbcInsert(dataSource)
 			.withTableName("owners")
 			.usingGeneratedKeyColumns("id");
+		
+		this.namedParameterJdbcTemplate = new NamedParameterJdbcTemplate(dataSource);
+
+		this.visitRepository = visitRepository;
 	}
 
 
@@ -72,10 +71,13 @@ public class JdbcOwnerRepositoryImpl implements OwnerRepository {
 	 */
 	@Transactional(readOnly = true)
 	public Collection<Owner> findByLastName(String lastName) throws DataAccessException {
-		List<Owner> owners = this.jdbcTemplate.query(
+		Map<String, Object> params = new HashMap<String, Object>();
-				"SELECT id, first_name, last_name, address, city, telephone FROM owners WHERE last_name like ?",
+		params.put("lastName", lastName + "%");
-				ParameterizedBeanPropertyRowMapper.newInstance(Owner.class),
+		List<Owner> owners = this.namedParameterJdbcTemplate.query(
-				lastName + "%");
+				"SELECT id, first_name, last_name, address, city, telephone FROM owners WHERE last_name like :lastName",
+				params, 
+				ParameterizedBeanPropertyRowMapper.newInstance(Owner.class)
+				);
 		loadOwnersPetsAndVisits(owners);
 		return owners;
 	}
@@ -89,10 +91,13 @@ public class JdbcOwnerRepositoryImpl implements OwnerRepository {
 	public Owner findById(int id) throws DataAccessException {
 		Owner owner;
 		try {
-			owner = this.jdbcTemplate.queryForObject(
+			Map<String, Object> params = new HashMap<String, Object>();
-					"SELECT id, first_name, last_name, address, city, telephone FROM owners WHERE id=?",
+			params.put("id", id);
-					ParameterizedBeanPropertyRowMapper.newInstance(Owner.class),
+			owner = this.namedParameterJdbcTemplate.queryForObject(
-					id);
+					"SELECT id, first_name, last_name, address, city, telephone FROM owners WHERE id= :id",
+					params,
+					ParameterizedBeanPropertyRowMapper.newInstance(Owner.class)
+					);
 		}
 		catch (EmptyResultDataAccessException ex) {
 			throw new ObjectRetrievalFailureException(Owner.class, new Integer(id));
@@ -102,10 +107,13 @@ public class JdbcOwnerRepositoryImpl implements OwnerRepository {
 	}
 	
 	public void loadPetsAndVisits(final Owner owner) {
-		final List<JdbcPet> pets = this.jdbcTemplate.query(
+		Map<String, Object> params = new HashMap<String, Object>();
-				"SELECT id, name, birth_date, type_id, owner_id FROM pets WHERE owner_id=?",
+		params.put("id", owner.getId().intValue());
-				new JdbcPetRowMapper(),
+		final List<JdbcPet> pets = this.namedParameterJdbcTemplate.query(
-				owner.getId().intValue());
+				"SELECT id, name, birth_date, type_id, owner_id FROM pets WHERE owner_id=:id",
+				params,
+				new JdbcPetRowMapper()
+				);
 		for (JdbcPet pet : pets) {
 			owner.addPet(pet);
 			pet.setType(EntityUtils.getById(getPetTypes(), PetType.class, pet.getTypeId()));
@@ -139,8 +147,8 @@ public class JdbcOwnerRepositoryImpl implements OwnerRepository {
 	
 	@Transactional(readOnly = true)
 	public Collection<PetType> getPetTypes() throws DataAccessException {
-		return this.jdbcTemplate.query(
+		return this.namedParameterJdbcTemplate.query(
-				"SELECT id, name FROM types ORDER BY name",
+				"SELECT id, name FROM types ORDER BY name", new HashMap<String,Object>(),
 				ParameterizedBeanPropertyRowMapper.newInstance(PetType.class));
 	}
 

src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcPetRepositoryImpl.java

@@ -1,13 +1,14 @@
 package org.springframework.samples.petclinic.repository.jdbc;
 
+import java.util.HashMap;
 import java.util.List;
+import java.util.Map;
 
 import javax.sql.DataSource;
 
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.dao.DataAccessException;
 import org.springframework.dao.EmptyResultDataAccessException;
-import org.springframework.jdbc.core.JdbcTemplate;
 import org.springframework.jdbc.core.namedparam.MapSqlParameterSource;
 import org.springframework.jdbc.core.namedparam.NamedParameterJdbcTemplate;
 import org.springframework.jdbc.core.simple.ParameterizedBeanPropertyRowMapper;
@@ -35,40 +36,44 @@ import org.springframework.stereotype.Repository;
 @Repository
 public class JdbcPetRepositoryImpl implements PetRepository {
 
-	private JdbcTemplate jdbcTemplate;
 	private NamedParameterJdbcTemplate namedParameterJdbcTemplate;
 
 	private SimpleJdbcInsert insertPet;
 	
-	@Autowired
 	private OwnerRepository ownerRepository;
 	
-	@Autowired
 	private VisitRepository visitRepository;
+	
 
 	@Autowired
-	public void init(DataSource dataSource) {
+	public JdbcPetRepositoryImpl(DataSource dataSource, OwnerRepository ownerRepository, VisitRepository visitRepository) {
-		this.jdbcTemplate = new JdbcTemplate(dataSource);
 		this.namedParameterJdbcTemplate = new NamedParameterJdbcTemplate(dataSource);
 
 		this.insertPet = new SimpleJdbcInsert(dataSource)
 			.withTableName("pets")
 			.usingGeneratedKeyColumns("id");
+		
+		this.ownerRepository = ownerRepository;
+		this.visitRepository = visitRepository;
 	}
 
 	public List<PetType> findPetTypes() throws DataAccessException {
-		return this.jdbcTemplate.query(
+		Map<String, Object> params = new HashMap<String,Object>();
+		return this.namedParameterJdbcTemplate.query(
 				"SELECT id, name FROM types ORDER BY name",
+				params,
 				ParameterizedBeanPropertyRowMapper.newInstance(PetType.class));
 	}
 
 	public Pet findById(int id) throws DataAccessException {
 		JdbcPet pet;
 		try {
-			pet = this.jdbcTemplate.queryForObject(
+			Map<String, Object> params = new HashMap<String, Object>();
-					"SELECT id, name, birth_date, type_id, owner_id FROM pets WHERE id=?",
+			params.put("id", id);
-					new JdbcPetRowMapper(),
+			pet = this.namedParameterJdbcTemplate.queryForObject(
-					id);
+					"SELECT id, name, birth_date, type_id, owner_id FROM pets WHERE id=:id",
+					params,
+					new JdbcPetRowMapper());
 		}
 		catch (EmptyResultDataAccessException ex) {
 			throw new ObjectRetrievalFailureException(Pet.class, new Integer(id));

src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcVisitRepositoryImpl.java

@@ -39,7 +39,7 @@ public class JdbcVisitRepositoryImpl implements VisitRepository {
 	private SimpleJdbcInsert insertVisit;
 
 	@Autowired
-	public void init(DataSource dataSource) {
+	public JdbcVisitRepositoryImpl(DataSource dataSource) {
 		this.jdbcTemplate = new JdbcTemplate(dataSource);
 
 		this.insertVisit = new SimpleJdbcInsert(dataSource)

src/main/java/org/springframework/samples/petclinic/web/OwnerController.java

@@ -66,8 +66,7 @@ public class OwnerController {
 	
 	@RequestMapping(value = "/owners/find", method = RequestMethod.GET)
 	public String initFindForm(Model model) {
-		model.addAttribute("owner", new Owner());
+		throw new RuntimeException("aaaaaaa");
-		return "owners/findOwners";
 	}
 
 	@RequestMapping(value = "/owners", method = RequestMethod.GET)

src/main/webapp/WEB-INF/petclinic-servlet.xml

@@ -94,6 +94,7 @@
 	-->
 	<bean class="org.springframework.web.servlet.handler.SimpleMappingExceptionResolver">
 		<property name="defaultErrorView" value="exception"/>
+		<property name="warnLogCategory" value="warn"/>
 	</bean>