updated

src/main/java/org/springframework/samples/petclinic/adapters/PetVaccinationService.java

@@ -8,7 +8,7 @@ import java.io.IOException;
 public interface PetVaccinationService {
 
 	@WithSpan
-	VaccinnationRecord[] AllVaccines() throws JSONException, IOException;
+	VaccinnationRecord[] allVaccines() throws JSONException, IOException;
 
 	@WithSpan
 	VaccinnationRecord VaccineRecord(int vaccinationRecordId) throws JSONException, IOException;

src/main/java/org/springframework/samples/petclinic/adapters/PetVaccinationServiceFacade.java

@@ -12,7 +12,6 @@ import org.springframework.stereotype.Component;
 
 import java.io.IOException;
 import java.time.Instant;
-import java.time.LocalDate;
 import java.util.ArrayList;
 
 @Component
@@ -20,7 +19,7 @@ public class PetVaccinationServiceFacade implements PetVaccinationService {
 
 	public static final String VACCINES_RECORDS_URL = "https://647f4bb4c246f166da9084c7.mockapi.io/api/vetcheck/vaccines";
 
-	private String MakeHttpCall(String url) throws IOException {
+	private String makeHttpCall(String url) throws IOException {
 
 		Request getAllVaccinesRequest = new Request.Builder().url(url).build();
 		OkHttpClient client = new OkHttpClient();
@@ -30,9 +29,9 @@ public class PetVaccinationServiceFacade implements PetVaccinationService {
 
 	@Override
 	@WithSpan
-	public VaccinnationRecord[] AllVaccines() throws JSONException, IOException {
+	public VaccinnationRecord[] allVaccines() throws JSONException, IOException {
 
-		var vaccineListString = MakeHttpCall(VACCINES_RECORDS_URL);
+		var vaccineListString = makeHttpCall(VACCINES_RECORDS_URL);
 		JSONArray jArr = new JSONArray(vaccineListString);
 		var vaccinnationRecords = new ArrayList<VaccinnationRecord>();
 
@@ -52,7 +51,7 @@ public class PetVaccinationServiceFacade implements PetVaccinationService {
 
 		var idUrl = VACCINES_RECORDS_URL + "/" + vaccinationRecordId;
 
-		var vaccineListString = MakeHttpCall(idUrl);
+		var vaccineListString = makeHttpCall(idUrl);
 
 		JSONObject vaccineJson = new JSONObject(vaccineListString);
 		return parseVaccinationRecord(vaccineJson);

src/main/java/org/springframework/samples/petclinic/domain/PetVaccinationStatusService.java

@@ -5,7 +5,6 @@ import io.opentelemetry.instrumentation.annotations.WithSpan;
 import org.json.JSONException;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.samples.petclinic.adapters.PetVaccinationService;
-import org.springframework.samples.petclinic.adapters.PetVaccinationServiceFacade;
 import org.springframework.samples.petclinic.adapters.VaccinnationRecord;
 import org.springframework.samples.petclinic.owner.Pet;
 import org.springframework.samples.petclinic.owner.PetVaccine;
@@ -21,12 +20,13 @@ public class PetVaccinationStatusService {
 	@Autowired
 	private PetVaccinationService adapter;
 
+
 	@WithSpan
 	public void UpdateVaccinationStatus(Pet[] pets) {
 
 		for (Pet pet : pets) {
 			try {
-				var vaccinationRecords = this.adapter.AllVaccines();
+				var vaccinationRecords = this.adapter.allVaccines();
 				for (VaccinnationRecord record : vaccinationRecords) {
 
 					var recordInfo = this.adapter.VaccineRecord(record.recordId());

src/main/java/org/springframework/samples/petclinic/owner/OwnerController.java

@@ -17,6 +17,8 @@ package org.springframework.samples.petclinic.owner;
 
 import java.util.List;
 import java.util.Map;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
 
 import io.opentelemetry.instrumentation.annotations.WithSpan;
 import org.springframework.data.domain.Page;
@@ -54,14 +56,15 @@ class OwnerController {
 
 	private OwnerValidation validator;
 
+
 	public OwnerController(OwnerRepository clinicService) {
 		this.owners = clinicService;
 		var otelTracer = getTracer("OwnerController");
-
 		validator = new OwnerValidation(otelTracer);
 
 	}
 
+
 	@InitBinder
 	public void setAllowedFields(WebDataBinder dataBinder) {
 		dataBinder.setDisallowedFields("id");
@@ -72,6 +75,7 @@ class OwnerController {
 		return ownerId == null ? new Owner() : this.owners.findById(ownerId);
 	}
 
+
 	@GetMapping("/owners/new")
 	public String initCreationForm(Map<String, Object> model) {
 

src/main/java/org/springframework/samples/petclinic/owner/PetController.java

@@ -16,7 +16,10 @@
 package org.springframework.samples.petclinic.owner;
 
 import java.util.Collection;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
 
+import org.springframework.beans.factory.InitializingBean;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.samples.petclinic.domain.PetVaccinationStatusService;
 import org.springframework.stereotype.Controller;
@@ -40,7 +43,7 @@ import jakarta.validation.Valid;
  */
 @Controller
 @RequestMapping("/owners/{ownerId}")
-class PetController {
+class PetController implements InitializingBean {
 
 	private static final String VIEWS_PETS_CREATE_OR_UPDATE_FORM = "pets/createOrUpdatePetForm";
 
@@ -49,10 +52,14 @@ class PetController {
 	@Autowired
 	private PetVaccinationStatusService petVaccinationStatus;
 
+	private ExecutorService executorService;
+
+
 	public PetController(OwnerRepository owners) {
 		this.owners = owners;
 	}
 
+
 	@ModelAttribute("types")
 	public Collection<PetType> populatePetTypes() {
 		return this.owners.findPetTypes();
@@ -101,7 +108,9 @@ class PetController {
 
 
 		this.owners.save(owner);
+		this.executorService.submit(() -> {
 			petVaccinationStatus.UpdateVaccinationStatus(owner.getPets().toArray(Pet[]::new));
+		});
 
 		return "redirect:/owners/{ownerId}";
 	}
@@ -125,4 +134,9 @@ class PetController {
 		return "redirect:/owners/{ownerId}";
 	}
 
+	@Override
+	public void afterPropertiesSet() throws Exception {
+		this.executorService = Executors.newFixedThreadPool(5);
+
+	}
 }

src/test/java/org/springframework/samples/petclinic/integration/OwnerControllerTests.java

@@ -73,7 +73,6 @@ public class OwnerControllerTests {
 
 		Owner owner = CreateOwner();
 
-		for (int i = 0; i < 3; i++) {
 
 		String newPetName = faker.dog().name();
 		given().contentType("multipart/form-data")
@@ -85,20 +84,13 @@ public class OwnerControllerTests {
 			.post(String.format("/owners/%s/pets/new", owner.getId()))
 			.then()
 			.statusCode(Matchers.not(Matchers.greaterThan(499)));
-			try {
-				Thread.sleep(800);
-			}
-			catch (InterruptedException e) {
-				throw new RuntimeException(e);
-			}
 
-		}
 
-		// var updatedOwner = ownerRepository.findById(owner.getId());
-		// assertThat(updatedOwner.getPets())
-		// .hasSize(2)
-		// .extracting(Pet::getName)
-		// .contains(newPetName);
+		 var updatedOwner = ownerRepository.findById(owner.getId());
+		 assertThat(updatedOwner.getPets())
+		 .hasSize(2)
+		 .extracting(Pet::getName)
+		 .contains(newPetName);
 
 	}