From a2a12c4d524624eec7196c745ac5dd3470867275 Mon Sep 17 00:00:00 2001 From: Mic Date: Fri, 14 Jun 2013 09:39:46 +0800 Subject: [PATCH] #18 Simplified Validator test so it doesn't have to use Spring config anymore --- .../petclinic/model/ValidatorTests-config.xml | 16 ---------------- .../samples/petclinic/model/ValidatorTests.java | 11 +++++++---- 2 files changed, 7 insertions(+), 20 deletions(-) delete mode 100644 src/test/java/org/springframework/samples/petclinic/model/ValidatorTests-config.xml diff --git a/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests-config.xml b/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests-config.xml deleted file mode 100644 index 4dd740157..000000000 --- a/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests-config.xml +++ /dev/null @@ -1,16 +0,0 @@ - - - - - - - - - diff --git a/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests.java b/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests.java index 298cf6bfe..354c15a9f 100644 --- a/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests.java +++ b/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests.java @@ -12,6 +12,7 @@ import org.junit.runner.RunWith; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.test.context.ContextConfiguration; import org.springframework.test.context.junit4.SpringJUnit4ClassRunner; +import org.springframework.validation.beanvalidation.LocalValidatorFactoryBean; /** * @@ -20,12 +21,13 @@ import org.springframework.test.context.junit4.SpringJUnit4ClassRunner; * (useful when upgrading to a new version of Hibernate Validator/ Bean Validation) * */ -@ContextConfiguration("ValidatorTests-config.xml") -@RunWith(SpringJUnit4ClassRunner.class) public class ValidatorTests { - @Autowired - private Validator validator; + private Validator createValidator() { + LocalValidatorFactoryBean localValidatorFactoryBean = new LocalValidatorFactoryBean(); + localValidatorFactoryBean.afterPropertiesSet(); + return localValidatorFactoryBean; + } @Test public void emptyFirstName() { @@ -34,6 +36,7 @@ public class ValidatorTests { person.setFirstName(""); person.setLastName("smith"); + Validator validator = createValidator(); Set> constraintViolations = validator.validate(person); Assert.assertEquals(1, constraintViolations.size());