diff --git a/pom.xml b/pom.xml index 59fdd7629..ffdbf51aa 100644 --- a/pom.xml +++ b/pom.xml @@ -66,6 +66,8 @@ 5.1.22 + 2.7 + @@ -442,8 +444,39 @@ /petclinic + + org.codehaus.mojo + cobertura-maven-plugin + ${cobertura.version} + + + + + + clean + check + + + + + + + + + + org.codehaus.mojo + cobertura-maven-plugin + ${cobertura.version} + + + html + + + + + demopetclinic diff --git a/src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcOwnerRepositoryImpl.java b/src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcOwnerRepositoryImpl.java index 4ae19653a..579de5284 100644 --- a/src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcOwnerRepositoryImpl.java +++ b/src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcOwnerRepositoryImpl.java @@ -122,6 +122,7 @@ public class JdbcOwnerRepositoryImpl implements OwnerRepository { ); for (JdbcPet pet : pets) { owner.addPet(pet); + // Pet types have not been loaded at this stage. They are loaded separately pet.setType(EntityUtils.getById(getPetTypes(), PetType.class, pet.getTypeId())); List visits = this.visitRepository.findByPetId(pet.getId()); for (Visit visit : visits) { diff --git a/src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcPet.java b/src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcPet.java index f2ed25823..39ba53b83 100644 --- a/src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcPet.java +++ b/src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcPet.java @@ -19,7 +19,7 @@ import org.springframework.samples.petclinic.model.Pet; /** * Subclass of Pet that carries temporary id properties which are only relevant for a JDBC implementation of the - * ClinicService. + * PetRepository. * * @author Juergen Hoeller */ diff --git a/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests.java b/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests.java index 0c80d06fb..f8582b5d9 100644 --- a/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests.java +++ b/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests.java @@ -8,8 +8,6 @@ import java.util.Set; import javax.validation.ConstraintViolation; import javax.validation.Validator; -import org.assertj.core.api.Assertions; -import org.junit.Assert; import org.junit.Test; import org.springframework.context.i18n.LocaleContextHolder; import org.springframework.validation.beanvalidation.LocalValidatorFactoryBean; @@ -40,7 +38,7 @@ public class ValidatorTests { Validator validator = createValidator(); Set> constraintViolations = validator.validate(person); - Assert.assertEquals(1, constraintViolations.size()); + assertThat(constraintViolations.size()).isEqualTo(1); ConstraintViolation violation = constraintViolations.iterator().next(); assertThat(violation.getPropertyPath().toString()).isEqualTo("firstName"); assertThat(violation.getMessage()).isEqualTo("may not be empty");