From aeec7104bac5259885cd34d7385c97f3b3fa4571 Mon Sep 17 00:00:00 2001
From: michaelisvy <misvy@gopivotal,com>
Date: Tue, 14 Apr 2015 09:27:25 +0800
Subject: [PATCH 1/3] Adding Maven config for Cobertura

---
 pom.xml | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/pom.xml b/pom.xml
index 59fdd7629..ffdbf51aa 100644
--- a/pom.xml
+++ b/pom.xml
@@ -66,6 +66,8 @@
 
 		<mysql.version>5.1.22</mysql.version>
 
+		<cobertura.version>2.7</cobertura.version>
+
 	</properties>
 
 	<dependencies>
@@ -442,8 +444,39 @@
 					<path>/petclinic</path>
 				</configuration>
 			</plugin>
+			 <plugin>
+		        <groupId>org.codehaus.mojo</groupId>
+		        <artifactId>cobertura-maven-plugin</artifactId>
+				<version>${cobertura.version}</version>
+		        <configuration>
+		        </configuration>
+		        <executions>
+		          <execution>
+		            <goals>
+		              <goal>clean</goal>
+		              <goal>check</goal>
+		            </goals>
+		          </execution>
+		        </executions>
+         </plugin>
 		</plugins>
 	</build>
+		<reporting>
+		<plugins>
+		 
+			<!--  integrate maven-cobertura-plugin to project site  -->
+			<plugin>
+				<groupId>org.codehaus.mojo</groupId>
+				<artifactId>cobertura-maven-plugin</artifactId>
+				<version>${cobertura.version}</version>
+				<configuration>
+					<formats>
+						<format>html</format>
+					</formats>
+				</configuration>
+			</plugin>
+		</plugins>
+	</reporting>
 
 	<url>demopetclinic</url>
 </project>

From 38a5b28e294b2d0827cf626cb68533a557e3a9e8 Mon Sep 17 00:00:00 2001
From: michaelisvy <misvy@gopivotal,com>
Date: Tue, 14 Apr 2015 09:27:41 +0800
Subject: [PATCH 2/3] Improving/fixing comments

---
 .../petclinic/repository/jdbc/JdbcOwnerRepositoryImpl.java      | 1 +
 .../samples/petclinic/repository/jdbc/JdbcPet.java              | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcOwnerRepositoryImpl.java b/src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcOwnerRepositoryImpl.java
index 4ae19653a..579de5284 100644
--- a/src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcOwnerRepositoryImpl.java
+++ b/src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcOwnerRepositoryImpl.java
@@ -122,6 +122,7 @@ public class JdbcOwnerRepositoryImpl implements OwnerRepository {
         );
         for (JdbcPet pet : pets) {
             owner.addPet(pet);
+            // Pet types have not been loaded at this stage. They are loaded separately
             pet.setType(EntityUtils.getById(getPetTypes(), PetType.class, pet.getTypeId()));
             List<Visit> visits = this.visitRepository.findByPetId(pet.getId());
             for (Visit visit : visits) {
diff --git a/src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcPet.java b/src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcPet.java
index f2ed25823..39ba53b83 100644
--- a/src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcPet.java
+++ b/src/main/java/org/springframework/samples/petclinic/repository/jdbc/JdbcPet.java
@@ -19,7 +19,7 @@ import org.springframework.samples.petclinic.model.Pet;
 
 /**
  * Subclass of Pet that carries temporary id properties which are only relevant for a JDBC implementation of the
- * ClinicService.
+ * PetRepository.
  *
  * @author Juergen Hoeller
  */

From 694390d0c2d80624f499ba4feea3ab1d598f009d Mon Sep 17 00:00:00 2001
From: michaelisvy <misvy@gopivotal,com>
Date: Sun, 10 May 2015 06:33:10 +0800
Subject: [PATCH 3/3] migrated assertion to assertJ

---
 .../samples/petclinic/model/ValidatorTests.java               | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests.java b/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests.java
index 0c80d06fb..f8582b5d9 100644
--- a/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests.java
+++ b/src/test/java/org/springframework/samples/petclinic/model/ValidatorTests.java
@@ -8,8 +8,6 @@ import java.util.Set;
 import javax.validation.ConstraintViolation;
 import javax.validation.Validator;
 
-import org.assertj.core.api.Assertions;
-import org.junit.Assert;
 import org.junit.Test;
 import org.springframework.context.i18n.LocaleContextHolder;
 import org.springframework.validation.beanvalidation.LocalValidatorFactoryBean;
@@ -40,7 +38,7 @@ public class ValidatorTests {
         Validator validator = createValidator();
         Set<ConstraintViolation<Person>> constraintViolations = validator.validate(person);
 
-        Assert.assertEquals(1, constraintViolations.size());
+        assertThat(constraintViolations.size()).isEqualTo(1);
         ConstraintViolation<Person> violation =  constraintViolations.iterator().next();
         assertThat(violation.getPropertyPath().toString()).isEqualTo("firstName");
         assertThat(violation.getMessage()).isEqualTo("may not be empty");