Patrick.Sy/spring-petclinic
1
0
Fork 0
mirror of https://github.com/spring-projects/spring-petclinic.git synced 2025-07-24 00:35:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactoring Owner getPets function to use lambda functions

Browse source
This commit is contained in:
Rafael De Oliveira Fantinel 2023-06-26 08:41:23 -03:00
parent 10e3dc9376
commit ede6d3866d
1 changed files with 14 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
src/main/java/org/springframework/samples/petclinic/owner/Owner.java
View file

@ -112,16 +112,13 @@ public class Owner extends Person {
* @param id to test
* @return a pet if pet id is already in use
*/
public Pet getPet(Integer id) {
for (Pet pet : getPets()) {
if (!pet.isNew()) {
Integer compId = pet.getId();
if (compId.equals(id)) {
return pet;
}
}
}
return null;
public Pet getPet(final Integer id) {
return getPets().stream()
.filter(pet -> !pet.isNew())
.filter(pet -> pet.getId().equals(id))
.findFirst()
.orElse(null);
}
/**
@ -129,18 +126,13 @@ public class Owner extends Person {
* @param name to test
* @return a pet if pet name is already in use
*/
public Pet getPet(String name, boolean ignoreNew) {
name = name.toLowerCase();
for (Pet pet : getPets()) {
if (!ignoreNew || !pet.isNew()) {
String compName = pet.getName();
compName = compName == null ? "" : compName.toLowerCase();
if (compName.equals(name)) {
return pet;
}
}
}
return null;
public Pet getPet(final String name, final boolean ignoreNew) {
return getPets().stream()
.filter(pet -> !ignoreNew && !pet.isNew())
.filter(pet -> pet.getName().equals(name.toLowerCase()))
.findFirst()
.orElse(null);
}
@Override