feat(argo-workflows): Include pod name in key format for GCS logs (#915)
* feat(argo-workflows) Include pod name in key format for GCS logs A better default would be to add the `pod.name` to the key format of the Argo logs. I noticed that when not including the pod name, it would constantly overwrite the same log from from different pods. Including it makes sure that each pod will have its own log file. Signed-off-by: Michiel De Mey <de.mey.michiel@gmail.com> * Bump chart version and added changelog Signed-off-by: Michiel De Mey <de.mey.michiel@gmail.com> Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
This commit is contained in:
parent
22575d4c62
commit
3088cf68b2
2 changed files with 3 additions and 3 deletions
|
@ -2,7 +2,7 @@ apiVersion: v2
|
|||
name: argo-workflows
|
||||
description: A Helm chart for Argo Workflows
|
||||
type: application
|
||||
version: 0.9.0
|
||||
version: 0.9.1
|
||||
appVersion: v3.2.4
|
||||
icon: https://raw.githubusercontent.com/argoproj/argo-workflows/master/docs/assets/argo.png
|
||||
home: https://github.com/argoproj/argo-helm
|
||||
|
@ -15,4 +15,4 @@ maintainers:
|
|||
- name: benjaminws
|
||||
annotations:
|
||||
artifacthub.io/changes: |
|
||||
- "[Added]: support resourceRateLimit config"
|
||||
- "[Changed]: Changed default GCP keyFormat"
|
||||
|
|
|
@ -476,7 +476,7 @@ artifactRepository:
|
|||
# @default -- `{}` (See [values.yaml])
|
||||
gcs: {}
|
||||
# bucket: <project>-argo
|
||||
# keyFormat: "{{workflow.namespace}}/{{workflow.name}}/"
|
||||
# keyFormat: "{{workflow.namespace}}/{{workflow.name}}/{{pod.name}}"
|
||||
# serviceAccountKeySecret is a secret selector.
|
||||
# It references the k8s secret named 'my-gcs-credentials'.
|
||||
# This secret is expected to have have the key 'serviceAccountKey',
|
||||
|
|
Loading…
Reference in a new issue