DevFW-CICD/argocd-helm
14
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(argo-workflows): Include pod name in key format for GCS logs (#915)

Browse source 
* feat(argo-workflows) Include pod name in key format for GCS logs

A better default would be to add the `pod.name` to the key format of the Argo logs.

I noticed that when not including the pod name, it would constantly overwrite the same log from from different pods.
Including it makes sure that each pod will have its own log file.

Signed-off-by: Michiel De Mey <de.mey.michiel@gmail.com>

* Bump chart version and added changelog

Signed-off-by: Michiel De Mey <de.mey.michiel@gmail.com>

Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
This commit is contained in:
Michiel De Mey 2021-11-22 10:40:42 +01:00 committed by GitHub
parent 22575d4c62
commit 3088cf68b2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
charts/argo-workflows/Chart.yaml
View file

@ -2,7 +2,7 @@ apiVersion: v2
name: argo-workflows name: argo-workflows
description: A Helm chart for Argo Workflows description: A Helm chart for Argo Workflows
type: application type: application
version: 0.9.0 version: 0.9.1
appVersion: v3.2.4 appVersion: v3.2.4
icon: https://raw.githubusercontent.com/argoproj/argo-workflows/master/docs/assets/argo.png icon: https://raw.githubusercontent.com/argoproj/argo-workflows/master/docs/assets/argo.png
home: https://github.com/argoproj/argo-helm home: https://github.com/argoproj/argo-helm
@ -15,4 +15,4 @@ maintainers:
- name: benjaminws - name: benjaminws
annotations: annotations:
artifacthub.io/changes: | artifacthub.io/changes: |
- "[Added]: support resourceRateLimit config" - "[Changed]: Changed default GCP keyFormat"

2
charts/argo-workflows/values.yaml
View file

@ -476,7 +476,7 @@ artifactRepository:
# @default -- `{}` (See [values.yaml]) # @default -- `{}` (See [values.yaml])
gcs: {} gcs: {}
# bucket: <project>-argo # bucket: <project>-argo
# keyFormat: "{{workflow.namespace}}/{{workflow.name}}/" # keyFormat: "{{workflow.namespace}}/{{workflow.name}}/{{pod.name}}"
# serviceAccountKeySecret is a secret selector. # serviceAccountKeySecret is a secret selector.
# It references the k8s secret named 'my-gcs-credentials'. # It references the k8s secret named 'my-gcs-credentials'.
# This secret is expected to have have the key 'serviceAccountKey', # This secret is expected to have have the key 'serviceAccountKey',