Apply suggestions from code review

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2021-08-10 11:28:54 +02:00 · 2021-08-10 11:28:54 +02:00 · f8d3f4dccc
commit f8d3f4dccc
parent 6a72cc9ea1
5 changed files with 4 additions and 3 deletions
--- a/charts/argo-cd/testhelm.yaml
+++ b/charts/argo-cd/testhelm.yaml
--- a/charts/argo-rollouts/Chart.yaml
+++ b/charts/argo-rollouts/Chart.yaml
@ -4,6 +4,7 @@ description: A Helm chart for Argo Rollouts
 name: argo-rollouts
 version: 1.1.0
 icon: https://argoproj.github.io/argo-rollouts/assets/logo.png
+)
 home: https://github.com/argoproj/argo-helm
 maintainers:
  - name: alexmt
--- a/charts/argo-rollouts/templates/dashboard/clusterrole.yaml
+++ b/charts/argo-rollouts/templates/dashboard/clusterrole.yaml
@ -1,4 +1,4 @@
-{{- if and ( eq .Values.dashboard.enabled true) ( eq .Values.clusterInstall true) }}
+{{- if and .Values.dashboard.enabled .Values.clusterInstall }}
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
--- a/charts/argo-rollouts/templates/dashboard/clusterrolebinding.yaml
+++ b/charts/argo-rollouts/templates/dashboard/clusterrolebinding.yaml
@ -1,4 +1,4 @@
-{{- if and ( eq .Values.dashboard.enabled true) ( eq .Values.clusterInstall true) }}
+{{- if and .Values.dashboard.enabled .Values.clusterInstall }}
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding
 metadata:
--- a/charts/argo-rollouts/templates/dashboard/sa.yaml
+++ b/charts/argo-rollouts/templates/dashboard/sa.yaml
@ -1,4 +1,4 @@
-{{- if and ( eq .Values.dashboard.enabled true) ( eq .Values.dashboard.serviceAccount.create true) }}
+{{- if and .Values.dashboard.enabled .Values.dashboard.serviceAccount.create }}
 apiVersion: v1
 kind: ServiceAccount
 metadata: