Use recommended labels and label helpers

Signed-off-by: Naseem <naseem@transit.app>

charts/ingress-nginx/templates/_helpers.tpl

@@ -61,6 +61,26 @@ We truncate at 63 chars because some Kubernetes name fields are limited to this
 {{- printf "%s-%s" (include "nginx-ingress.fullname" .) .Values.defaultBackend.name | trunc 63 | trimSuffix "-" -}}
 {{- end -}}
 
+{{/*
+Common labels
+*/}}
+{{- define "nginx-ingress.labels" -}}
+helm.sh/chart: {{ include "nginx-ingress.chart" . }}
+{{ include "nginx-ingress.selectorLabels" . }}
+{{- if .Chart.AppVersion }}
+app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
+{{- end }}
+app.kubernetes.io/managed-by: {{ .Release.Service }}
+{{- end -}}
+
+{{/*
+Selector labels
+*/}}
+{{- define "nginx-ingress.selectorLabels" -}}
+app.kubernetes.io/name: {{ include "nginx-ingress.name" . }}
+app.kubernetes.io/instance: {{ .Release.Name }}
+{{- end -}}
+
 {{/*
 Create the name of the controller service account to use
 */}}

charts/ingress-nginx/templates/addheaders-configmap.yaml

@@ -3,12 +3,9 @@ apiVersion: v1
 kind: ConfigMap
 metadata:
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    component: "{{ .Values.controller.name }}"
+  name: {{ include "nginx-ingress.fullname" . }}-custom-add-headers
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
-  name: {{ template "nginx-ingress.fullname" . }}-custom-add-headers
 data:
 {{ toYaml .Values.controller.addHeaders | indent 2 }}
 {{- end }}

charts/ingress-nginx/templates/admission-webhooks/job-patch/clusterrole.yaml

@@ -2,16 +2,13 @@
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
-  name:  {{ template "nginx-ingress.fullname" . }}-admission
+  name:  {{ include "nginx-ingress.fullname" . }}-admission
   annotations:
     "helm.sh/hook": pre-install,pre-upgrade,post-install,post-upgrade
     "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    component: "{{ .Values.controller.name }}"
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
 rules:
   - apiGroups:
       - admissionregistration.k8s.io
@@ -25,6 +22,6 @@ rules:
     resources: ['podsecuritypolicies']
     verbs:     ['use']
     resourceNames:
-    - {{ template "nginx-ingress.fullname" . }}-admission
+    - {{ include "nginx-ingress.fullname" . }}-admission
 {{- end }}
 {{- end }}

charts/ingress-nginx/templates/admission-webhooks/job-patch/clusterrolebinding.yaml

@@ -2,22 +2,19 @@
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding
 metadata:
-  name:  {{ template "nginx-ingress.fullname" . }}-admission
+  name:  {{ include "nginx-ingress.fullname" . }}-admission
   annotations:
     "helm.sh/hook": pre-install,pre-upgrade,post-install,post-upgrade
     "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    component: "{{ .Values.controller.name }}"
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: ClusterRole
-  name: {{ template "nginx-ingress.fullname" . }}-admission
+  name: {{ include "nginx-ingress.fullname" . }}-admission
 subjects:
   - kind: ServiceAccount
-    name: {{ template "nginx-ingress.fullname" . }}-admission
+    name: {{ include "nginx-ingress.fullname" . }}-admission
     namespace: {{ .Release.Namespace }}
 {{- end }}

charts/ingress-nginx/templates/admission-webhooks/job-patch/job-createSecret.yaml

@@ -2,16 +2,13 @@
 apiVersion: batch/v1
 kind: Job
 metadata:
-  name: {{ template "nginx-ingress.fullname" . }}-admission-create
+  name: {{ include "nginx-ingress.fullname" . }}-admission-create
   annotations:
     "helm.sh/hook": pre-install,pre-upgrade
     "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    component: "{{ .Values.controller.name }}"
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
 spec:
   {{- if .Capabilities.APIVersions.Has "batch/v1alpha1" }}
   # Alpha feature since k8s 1.12
@@ -19,17 +16,14 @@ spec:
   {{- end }}
   template:
     metadata:
-      name: {{ template "nginx-ingress.fullname" . }}-admission-create
+      name: {{ include "nginx-ingress.fullname" . }}-admission-create
 {{- with .Values.controller.admissionWebhooks.patch.podAnnotations }}
       annotations:
 {{ toYaml .  | indent 8 }}
 {{- end }}
       labels:
-        app: {{ template "nginx-ingress.name" . }}
+        {{- include "nginx-ingress.labels" . | nindent 8 }}
-        chart: {{ template "nginx-ingress.chart" . }}
+        app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-        component: "{{ .Values.controller.name }}"
-        heritage: {{ .Release.Service }}
-        release: {{ .Release.Name }}
     spec:
       {{- if .Values.controller.admissionWebhooks.patch.priorityClassName }}
       priorityClassName: {{ .Values.controller.admissionWebhooks.patch.priorityClassName }}
@@ -44,7 +38,7 @@ spec:
             - --namespace={{ .Release.Namespace }}
             - --secret-name={{ template "nginx-ingress.fullname". }}-admission
       restartPolicy: OnFailure
-      serviceAccountName: {{ template "nginx-ingress.fullname" . }}-admission
+      serviceAccountName: {{ include "nginx-ingress.fullname" . }}-admission
       {{- with .Values.controller.admissionWebhooks.patch.nodeSelector }}
       nodeSelector:
 {{ toYaml . | indent 8 }}

charts/ingress-nginx/templates/admission-webhooks/job-patch/job-patchWebhook.yaml

@@ -2,16 +2,13 @@
 apiVersion: batch/v1
 kind: Job
 metadata:
-  name: {{ template "nginx-ingress.fullname" . }}-admission-patch
+  name: {{ include "nginx-ingress.fullname" . }}-admission-patch
   annotations:
     "helm.sh/hook": post-install,post-upgrade
     "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    component: "{{ .Values.controller.name }}"
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
 spec:
   {{- if .Capabilities.APIVersions.Has "batch/v1alpha1" }}
   # Alpha feature since k8s 1.12
@@ -19,17 +16,14 @@ spec:
   {{- end }}
   template:
     metadata:
-      name:   {{ template "nginx-ingress.fullname" . }}-admission-patch
+      name:   {{ include "nginx-ingress.fullname" . }}-admission-patch
 {{- with .Values.controller.admissionWebhooks.patch.podAnnotations }}
       annotations:
 {{ toYaml .  | indent 8 }}
 {{- end }}
       labels:
-        app: {{ template "nginx-ingress.name" . }}
+        {{- include "nginx-ingress.labels" . | nindent 8 }}
-        chart: {{ template "nginx-ingress.chart" . }}
+        app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-        component: "{{ .Values.controller.name }}"
-        heritage: {{ .Release.Service }}
-        release: {{ .Release.Name }}
     spec:
       {{- if .Values.controller.admissionWebhooks.patch.priorityClassName }}
       priorityClassName: {{ .Values.controller.admissionWebhooks.patch.priorityClassName }}
@@ -40,13 +34,13 @@ spec:
           imagePullPolicy: {{ .Values.controller.admissionWebhooks.patch.pullPolicy }}
           args:
             - patch
-            - --webhook-name={{ template "nginx-ingress.fullname" . }}-admission
+            - --webhook-name={{ include "nginx-ingress.fullname" . }}-admission
             - --namespace={{ .Release.Namespace }}
             - --patch-mutating=false
             - --secret-name={{ template "nginx-ingress.fullname". }}-admission
             - --patch-failure-policy={{ .Values.controller.admissionWebhooks.failurePolicy }}
       restartPolicy: OnFailure
-      serviceAccountName: {{ template "nginx-ingress.fullname" . }}-admission
+      serviceAccountName: {{ include "nginx-ingress.fullname" . }}-admission
       {{- with .Values.controller.admissionWebhooks.patch.nodeSelector }}
       nodeSelector:
 {{ toYaml . | indent 8 }}

charts/ingress-nginx/templates/admission-webhooks/job-patch/psp.yaml

@@ -2,16 +2,13 @@
 apiVersion: policy/v1beta1
 kind: PodSecurityPolicy
 metadata:
-  name: {{ template "nginx-ingress.fullname" . }}-admission
+  name: {{ include "nginx-ingress.fullname" . }}-admission
   annotations:
     "helm.sh/hook": pre-install,pre-upgrade,post-install,post-upgrade
     "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    component: "{{ .Values.controller.name }}"
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
 spec:
   allowPrivilegeEscalation: false
   fsGroup:

charts/ingress-nginx/templates/admission-webhooks/job-patch/role.yaml

@@ -2,16 +2,13 @@
 apiVersion: rbac.authorization.k8s.io/v1
 kind: Role
 metadata:
-  name:  {{ template "nginx-ingress.fullname" . }}-admission
+  name:  {{ include "nginx-ingress.fullname" . }}-admission
   annotations:
     "helm.sh/hook": pre-install,pre-upgrade,post-install,post-upgrade
     "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    component: "{{ .Values.controller.name }}"
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
 rules:
   - apiGroups:
       - ""

charts/ingress-nginx/templates/admission-webhooks/job-patch/rolebinding.yaml

@@ -2,22 +2,19 @@
 apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
-  name:  {{ template "nginx-ingress.fullname" . }}-admission
+  name:  {{ include "nginx-ingress.fullname" . }}-admission
   annotations:
     "helm.sh/hook": pre-install,pre-upgrade,post-install,post-upgrade
     "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    component: "{{ .Values.controller.name }}"
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: Role
-  name: {{ template "nginx-ingress.fullname" . }}-admission
+  name: {{ include "nginx-ingress.fullname" . }}-admission
 subjects:
   - kind: ServiceAccount
-    name: {{ template "nginx-ingress.fullname" . }}-admission
+    name: {{ include "nginx-ingress.fullname" . }}-admission
     namespace: {{ .Release.Namespace }}
 {{- end }}

charts/ingress-nginx/templates/admission-webhooks/job-patch/serviceaccount.yaml

@@ -2,14 +2,11 @@
 apiVersion: v1
 kind: ServiceAccount
 metadata:
-  name:  {{ template "nginx-ingress.fullname" . }}-admission
+  name:  {{ include "nginx-ingress.fullname" . }}-admission
   annotations:
     "helm.sh/hook": pre-install,pre-upgrade,post-install,post-upgrade
     "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    component: "{{ .Values.controller.name }}"
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
 {{- end }}

charts/ingress-nginx/templates/admission-webhooks/validating-webhook.yaml

@@ -3,12 +3,9 @@ apiVersion: admissionregistration.k8s.io/v1beta1
 kind: ValidatingWebhookConfiguration
 metadata:
   labels:
-    app: {{ template "nginx-ingress.name" . }}-admission
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: admission-webhook
-    component: "admission-webhook"
+  name: {{ include "nginx-ingress.fullname" . }}-admission
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
-  name: {{ template "nginx-ingress.fullname" . }}-admission
 webhooks:
   - name: validate.nginx.ingress.kubernetes.io
     rules:

charts/ingress-nginx/templates/clusterrole.yaml

@@ -3,11 +3,8 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+  name: {{ include "nginx-ingress.fullname" . }}
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
-  name: {{ template "nginx-ingress.fullname" . }}
 rules:
   - apiGroups:
       - ""

charts/ingress-nginx/templates/clusterrolebinding.yaml

@@ -3,15 +3,12 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding
 metadata:
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+  name: {{ include "nginx-ingress.fullname" . }}
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
-  name: {{ template "nginx-ingress.fullname" . }}
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: ClusterRole
-  name: {{ template "nginx-ingress.fullname" . }}
+  name: {{ include "nginx-ingress.fullname" . }}
 subjects:
   - kind: ServiceAccount
     name: {{ template "nginx-ingress.serviceAccountName" . }}

charts/ingress-nginx/templates/controller-configmap.yaml

@@ -3,20 +3,17 @@ apiVersion: v1
 kind: ConfigMap
 metadata:
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    component: "{{ .Values.controller.name }}"
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
   annotations:
 {{ toYaml .Values.controller.configAnnotations | indent 4}}
   name: {{ template "nginx-ingress.controller.fullname" . }}
 data:
 {{- if .Values.controller.addHeaders }}
-  add-headers: {{ .Release.Namespace }}/{{ template "nginx-ingress.fullname" . }}-custom-add-headers
+  add-headers: {{ .Release.Namespace }}/{{ include "nginx-ingress.fullname" . }}-custom-add-headers
 {{- end }}
 {{- if or .Values.controller.proxySetHeaders .Values.controller.headers }}
-  proxy-set-headers: {{ .Release.Namespace }}/{{ template "nginx-ingress.fullname" . }}-custom-proxy-headers
+  proxy-set-headers: {{ .Release.Namespace }}/{{ include "nginx-ingress.fullname" . }}-custom-proxy-headers
 {{- end }}
 {{- if .Values.controller.config }}
 {{ toYaml .Values.controller.config | indent 2 }}

charts/ingress-nginx/templates/controller-daemonset.yaml

@@ -5,19 +5,16 @@ apiVersion: {{ template "deployment.apiVersion" . }}
 kind: DaemonSet
 metadata:
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    component: "{{ .Values.controller.name }}"
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
   name: {{ template "nginx-ingress.controller.fullname" . }}
   annotations:
 {{ toYaml .Values.controller.deploymentAnnotations | indent 4}}
 spec:
   selector:
     matchLabels:
-      app: {{ template "nginx-ingress.name" . }}
+      {{- include "nginx-ingress.selectorLabels" . | nindent 6 }}
-      release: {{ .Release.Name }}
+      app.kubernetes.io/component: {{ .Values.controller.name | quote }}
   revisionHistoryLimit: {{ .Values.revisionHistoryLimit }}
   updateStrategy:
 {{ toYaml .Values.controller.updateStrategy | indent 4 }}
@@ -31,9 +28,8 @@ spec:
       {{- end }}
       {{- end }}
       labels:
-        app: {{ template "nginx-ingress.name" . }}
+        {{- include "nginx-ingress.selectorLabels" . | nindent 8 }}
-        component: "{{ .Values.controller.name }}"
+        app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-        release: {{ .Release.Name }}
         {{- if .Values.controller.podLabels }}
 {{ toYaml .Values.controller.podLabels | indent 8}}
         {{- end }}
@@ -88,10 +84,10 @@ spec:
             - --nginx-configmap={{ .Release.Namespace }}/{{ template "nginx-ingress.controller.fullname" . }}
           {{- end }}
           {{- if .Values.tcp }}
-            - --tcp-services-configmap={{ .Release.Namespace }}/{{ template "nginx-ingress.fullname" . }}-tcp
+            - --tcp-services-configmap={{ .Release.Namespace }}/{{ include "nginx-ingress.fullname" . }}-tcp
           {{- end }}
           {{- if .Values.udp }}
-            - --udp-services-configmap={{ .Release.Namespace }}/{{ template "nginx-ingress.fullname" . }}-udp
+            - --udp-services-configmap={{ .Release.Namespace }}/{{ include "nginx-ingress.fullname" . }}-udp
           {{- end }}
           {{- if .Values.controller.scope.enabled }}
             - --watch-namespace={{ default .Release.Namespace .Values.controller.scope.namespace }}

charts/ingress-nginx/templates/controller-deployment.yaml

@@ -3,19 +3,16 @@ apiVersion: {{ template "deployment.apiVersion" . }}
 kind: Deployment
 metadata:
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    component: "{{ .Values.controller.name }}"
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
   name: {{ template "nginx-ingress.controller.fullname" . }}
   annotations:
 {{ toYaml .Values.controller.deploymentAnnotations | indent 4}}
 spec:
   selector:
     matchLabels:
-      app: {{ template "nginx-ingress.name" . }}
+      {{- include "nginx-ingress.selectorLabels" . | nindent 6 }}
-      release: {{ .Release.Name }}
+      app.kubernetes.io/component: {{ .Values.controller.name | quote }}
 {{- if not .Values.controller.autoscaling.enabled }}
   replicas: {{ .Values.controller.replicaCount }}
 {{- end }}
@@ -32,9 +29,8 @@ spec:
       {{- end }}
       {{- end }}
       labels:
-        app: {{ template "nginx-ingress.name" . }}
+        {{- include "nginx-ingress.selectorLabels" . | nindent 8 }}
-        component: "{{ .Values.controller.name }}"
+        app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-        release: {{ .Release.Name }}
         {{- if .Values.controller.podLabels }}
 {{ toYaml .Values.controller.podLabels | indent 8 }}
         {{- end }}
@@ -89,10 +85,10 @@ spec:
             - --nginx-configmap={{ default .Release.Namespace .Values.controller.configMapNamespace }}/{{ template "nginx-ingress.controller.fullname" . }}
           {{- end }}
           {{- if .Values.tcp }}
-            - --tcp-services-configmap={{ default .Release.Namespace .Values.controller.tcp.configMapNamespace }}/{{ template "nginx-ingress.fullname" . }}-tcp
+            - --tcp-services-configmap={{ default .Release.Namespace .Values.controller.tcp.configMapNamespace }}/{{ include "nginx-ingress.fullname" . }}-tcp
           {{- end }}
           {{- if .Values.udp }}
-            - --udp-services-configmap={{ default .Release.Namespace .Values.controller.udp.configMapNamespace }}/{{ template "nginx-ingress.fullname" . }}-udp
+            - --udp-services-configmap={{ default .Release.Namespace .Values.controller.udp.configMapNamespace }}/{{ include "nginx-ingress.fullname" . }}-udp
           {{- end }}
           {{- if .Values.controller.scope.enabled }}
             - --watch-namespace={{ default .Release.Namespace .Values.controller.scope.namespace }}

charts/ingress-nginx/templates/controller-hpa.yaml

@@ -4,11 +4,8 @@ apiVersion: autoscaling/v2beta1
 kind: HorizontalPodAutoscaler
 metadata:
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    component: "{{ .Values.controller.name }}"
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
   name: {{ template "nginx-ingress.controller.fullname" . }}
 spec:
   scaleTargetRef:

charts/ingress-nginx/templates/controller-metrics-service.yaml

@@ -12,11 +12,8 @@ metadata:
 {{- if .Values.controller.metrics.service.labels }}
 {{ toYaml .Values.controller.metrics.service.labels | indent 4 }}
 {{- end }}
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    component: "{{ .Values.controller.name }}"
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
   name: {{ template "nginx-ingress.controller.fullname" . }}-metrics
 spec:
 {{- if not .Values.controller.metrics.service.omitClusterIP }}
@@ -40,8 +37,7 @@ spec:
       port: {{ .Values.controller.metrics.service.servicePort }}
       targetPort: metrics
   selector:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.selectorLabels" . | nindent 4 }}
-    component: "{{ .Values.controller.name }}"
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    release: {{ .Release.Name }}
   type: "{{ .Values.controller.metrics.service.type }}"
 {{- end }}

charts/ingress-nginx/templates/controller-poddisruptionbudget.yaml

@@ -3,17 +3,13 @@ apiVersion: policy/v1beta1
 kind: PodDisruptionBudget
 metadata:
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    component: "{{ .Values.controller.name }}"
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
   name: {{ template "nginx-ingress.controller.fullname" . }}
 spec:
   selector:
     matchLabels:
-      app: {{ template "nginx-ingress.name" . }}
+      {{- include "nginx-ingress.selectorLabels" . | nindent 6 }}
-      release: {{ .Release.Name }}
+      app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-      component: "{{ .Values.controller.name }}"
   minAvailable: {{ .Values.controller.minAvailable }}
 {{- end }}

charts/ingress-nginx/templates/controller-prometheusrules.yaml

@@ -7,11 +7,8 @@ metadata:
   namespace: {{ .Values.controller.metrics.prometheusRule.namespace }}
   {{- end }}
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    component: "{{ .Values.controller.name }}"
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
     {{- if .Values.controller.metrics.prometheusRule.additionalLabels }}
 {{ toYaml .Values.controller.metrics.prometheusRule.additionalLabels | indent 4 }}
     {{- end }}

charts/ingress-nginx/templates/controller-psp.yaml

@@ -2,12 +2,10 @@
 apiVersion: {{ template "podSecurityPolicy.apiVersion" . }}
 kind: PodSecurityPolicy
 metadata:
-  name: {{ template "nginx-ingress.fullname" . }}
+  name: {{ include "nginx-ingress.fullname" . }}
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
 spec:
   allowedCapabilities:
     - NET_BIND_SERVICE

charts/ingress-nginx/templates/controller-role.yaml

@@ -3,11 +3,9 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: Role
 metadata:
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    heritage: {{ .Release.Service }}
+  name: {{ include "nginx-ingress.fullname" . }}
-    release: {{ .Release.Name }}
-  name: {{ template "nginx-ingress.fullname" . }}
 rules:
   - apiGroups:
       - ""
@@ -85,7 +83,7 @@ rules:
   - apiGroups:      ['{{ template "podSecurityPolicy.apiGroup" . }}']
     resources:      ['podsecuritypolicies']
     verbs:          ['use']
-    resourceNames:  [{{ template "nginx-ingress.fullname" . }}]
+    resourceNames:  [{{ include "nginx-ingress.fullname" . }}]
 {{- end }}
 
 {{- end -}}

charts/ingress-nginx/templates/controller-rolebinding.yaml

@@ -3,15 +3,13 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    heritage: {{ .Release.Service }}
+  name: {{ include "nginx-ingress.fullname" . }}
-    release: {{ .Release.Name }}
-  name: {{ template "nginx-ingress.fullname" . }}
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: Role
-  name: {{ template "nginx-ingress.fullname" . }}
+  name: {{ include "nginx-ingress.fullname" . }}
 subjects:
   - kind: ServiceAccount
     name: {{ template "nginx-ingress.serviceAccountName" . }}

charts/ingress-nginx/templates/controller-service.yaml

@@ -12,11 +12,8 @@ metadata:
 {{- if .Values.controller.service.labels }}
 {{ toYaml .Values.controller.service.labels | indent 4 }}
 {{- end }}
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    component: "{{ .Values.controller.name }}"
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
   name: {{ template "nginx-ingress.controller.fullname" . }}
 spec:
 {{- if not .Values.controller.service.omitClusterIP }}
@@ -87,8 +84,7 @@ spec:
      {{- end }}
   {{- end }}
   selector:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.selectorLabels" . | nindent 4 }}
-    component: "{{ .Values.controller.name }}"
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    release: {{ .Release.Name }}
   type: "{{ .Values.controller.service.type }}"
 {{- end }}

charts/ingress-nginx/templates/controller-serviceaccount.yaml

@@ -3,9 +3,7 @@ apiVersion: v1
 kind: ServiceAccount
 metadata:
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
   name: {{ template "nginx-ingress.serviceAccountName" . }}
 {{- end -}}

charts/ingress-nginx/templates/controller-servicemonitor.yaml

@@ -7,11 +7,8 @@ metadata:
   namespace: {{ .Values.controller.metrics.serviceMonitor.namespace }}
   {{- end }}
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    component: "{{ .Values.controller.name }}"
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
     {{- if .Values.controller.metrics.serviceMonitor.additionalLabels }}
 {{ toYaml .Values.controller.metrics.serviceMonitor.additionalLabels | indent 4 }}
     {{- end }}
@@ -32,7 +29,6 @@ spec:
   {{- end }}
   selector:
     matchLabels:
-      app: {{ template "nginx-ingress.name" . }}
+      {{- include "nginx-ingress.selectorLabels" . | nindent 6 }}
-      component: "{{ .Values.controller.name }}"
+      app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-      release: {{ .Release.Name }}
 {{- end }}

charts/ingress-nginx/templates/controller-webhook-service.yaml

@@ -9,11 +9,8 @@ metadata:
   {{- end }}
 {{- end }}
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    component: "{{ .Values.controller.name }}"
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
   name: {{ template "nginx-ingress.controller.fullname" . }}-admission
 spec:
 {{- if not .Values.controller.admissionWebhooks.service.omitClusterIP }}
@@ -37,8 +34,7 @@ spec:
       port: 443
       targetPort: webhook
   selector:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.selectorLabels" . | nindent 4 }}
-    component: "{{ .Values.controller.name }}"
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    release: {{ .Release.Name }}
   type: "{{ .Values.controller.admissionWebhooks.service.type }}"
 {{- end }}

charts/ingress-nginx/templates/default-backend-deployment.yaml

@@ -3,17 +3,14 @@ apiVersion: {{ template "deployment.apiVersion" . }}
 kind: Deployment
 metadata:
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.defaultBackend.name | quote }}
-    component: "{{ .Values.defaultBackend.name }}"
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
   name: {{ template "nginx-ingress.defaultBackend.fullname" . }}
 spec:
   selector:
     matchLabels:
-      app: {{ template "nginx-ingress.name" . }}
+      {{- include "nginx-ingress.selectorLabels" . | nindent 6 }}
-      release: {{ .Release.Name }}
+      app.kubernetes.io/component: {{ .Values.defaultBackend.name | quote }}
   replicas: {{ .Values.defaultBackend.replicaCount }}
   revisionHistoryLimit: {{ .Values.revisionHistoryLimit }}
   template:
@@ -25,9 +22,8 @@ spec:
       {{- end }}
     {{- end }}
       labels:
-        app: {{ template "nginx-ingress.name" . }}
+        {{- include "nginx-ingress.selectorLabels" . | nindent 8 }}
-        component: "{{ .Values.defaultBackend.name }}"
+        app.kubernetes.io/component: {{ .Values.defaultBackend.name | quote }}
-        release: {{ .Release.Name }}
         {{- if .Values.defaultBackend.podLabels }}
 {{ toYaml .Values.defaultBackend.podLabels | indent 8 }}
         {{- end }}

charts/ingress-nginx/templates/default-backend-poddisruptionbudget.yaml

@@ -3,17 +3,13 @@ apiVersion: policy/v1beta1
 kind: PodDisruptionBudget
 metadata:
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.defaultBackend.name | quote }}
-    component: "{{ .Values.defaultBackend.name }}"
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
   name: {{ template "nginx-ingress.defaultBackend.fullname" . }}
 spec:
   selector:
     matchLabels:
-      app: {{ template "nginx-ingress.name" . }}
+      {{- include "nginx-ingress.selectorLabels" . | nindent 6 }}
-      release: {{ .Release.Name }}
+      app.kubernetes.io/component: {{ .Values.defaultBackend.name | quote }}
-      component: "{{ .Values.defaultBackend.name }}"
   minAvailable: {{ .Values.defaultBackend.minAvailable }}
 {{- end }}

charts/ingress-nginx/templates/default-backend-psp.yaml

@@ -2,12 +2,10 @@
 apiVersion: {{ template "podSecurityPolicy.apiVersion" . }}
 kind: PodSecurityPolicy
 metadata:
-  name: {{ template "nginx-ingress.fullname" . }}-backend
+  name: {{ include "nginx-ingress.fullname" . }}-backend
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.defaultBackend.name | quote }}
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
 spec:
   allowPrivilegeEscalation: false
   fsGroup:

charts/ingress-nginx/templates/default-backend-role.yaml

@@ -3,14 +3,12 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: Role
 metadata:
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.defaultBackend.name | quote }}
-    heritage: {{ .Release.Service }}
+  name: {{ include "nginx-ingress.fullname" . }}-backend
-    release: {{ .Release.Name }}
-  name: {{ template "nginx-ingress.fullname" . }}-backend
 rules:
   - apiGroups:      ['{{ template "podSecurityPolicy.apiGroup" . }}']
     resources:      ['podsecuritypolicies']
     verbs:          ['use']
-    resourceNames:  [{{ template "nginx-ingress.fullname" . }}-backend]
+    resourceNames:  [{{ include "nginx-ingress.fullname" . }}-backend]
 {{- end -}}

charts/ingress-nginx/templates/default-backend-rolebinding.yaml

@@ -3,15 +3,13 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.defaultBackend.name | quote }}
-    heritage: {{ .Release.Service }}
+  name: {{ include "nginx-ingress.fullname" . }}-backend
-    release: {{ .Release.Name }}
-  name: {{ template "nginx-ingress.fullname" . }}-backend
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: Role
-  name: {{ template "nginx-ingress.fullname" . }}-backend
+  name: {{ include "nginx-ingress.fullname" . }}-backend
 subjects:
   - kind: ServiceAccount
     name: {{ template "nginx-ingress.defaultBackend.serviceAccountName" . }}

charts/ingress-nginx/templates/default-backend-service.yaml

@@ -9,11 +9,8 @@ metadata:
   {{- end }}
 {{- end }}
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.defaultBackend.name | quote }}
-    component: "{{ .Values.defaultBackend.name }}"
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
   name: {{ template "nginx-ingress.defaultBackend.fullname" . }}
 spec:
 {{- if not .Values.defaultBackend.service.omitClusterIP }}
@@ -38,8 +35,7 @@ spec:
       protocol: TCP
       targetPort: http
   selector:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.selectorLabels" . | nindent 4 }}
-    component: "{{ .Values.defaultBackend.name }}"
+    app.kubernetes.io/component: {{ .Values.defaultBackend.name | quote }}
-    release: {{ .Release.Name }}
   type: "{{ .Values.defaultBackend.service.type }}"
 {{- end }}

charts/ingress-nginx/templates/default-backend-serviceaccount.yaml

@@ -3,9 +3,7 @@ apiVersion: v1
 kind: ServiceAccount
 metadata:
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.defaultBackend.name | quote }}
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
   name: {{ template "nginx-ingress.defaultBackend.serviceAccountName" . }}
 {{- end }}

charts/ingress-nginx/templates/proxyheaders-configmap.yaml

@@ -3,12 +3,9 @@ apiVersion: v1
 kind: ConfigMap
 metadata:
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    component: "{{ .Values.controller.name }}"
+  name: {{ include "nginx-ingress.fullname" . }}-custom-proxy-headers
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
-  name: {{ template "nginx-ingress.fullname" . }}-custom-proxy-headers
 data:
 {{- if .Values.controller.proxySetHeaders }}
 {{ toYaml .Values.controller.proxySetHeaders | indent 2 }}

charts/ingress-nginx/templates/tcp-configmap.yaml

@@ -3,14 +3,11 @@ apiVersion: v1
 kind: ConfigMap
 metadata:
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    component: "{{ .Values.controller.name }}"
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
   annotations:
 {{ toYaml .Values.controller.tcp.annotations | indent 4}}
-  name: {{ template "nginx-ingress.fullname" . }}-tcp
+  name: {{ include "nginx-ingress.fullname" . }}-tcp
 data:
 {{ tpl (toYaml .Values.tcp) . | indent 2 }}
 {{- end }}

charts/ingress-nginx/templates/udp-configmap.yaml

@@ -3,14 +3,11 @@ apiVersion: v1
 kind: ConfigMap
 metadata:
   labels:
-    app: {{ template "nginx-ingress.name" . }}
+    {{- include "nginx-ingress.labels" . | nindent 4 }}
-    chart: {{ template "nginx-ingress.chart" . }}
+    app.kubernetes.io/component: {{ .Values.controller.name | quote }}
-    component: "{{ .Values.controller.name }}"
-    heritage: {{ .Release.Service }}
-    release: {{ .Release.Name }}
   annotations:
 {{ toYaml .Values.controller.udp.annotations | indent 4}}
-  name: {{ template "nginx-ingress.fullname" . }}-udp
+  name: {{ include "nginx-ingress.fullname" . }}-udp
 data:
 {{ tpl (toYaml .Values.udp) . | indent 2 }}
 {{- end }}