DevFW-CICD/ingress-nginx-helm
15
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Do not allow invalid latency values in metrics

Browse source
This commit is contained in:
Manuel de Brito Fontes 2018-07-24 10:53:46 -04:00
parent 43aabfc813
commit 010342aa58
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
internal/ingress/metric/collectors/socket.go
View file

@ -236,11 +236,13 @@ func (sc *SocketCollector) handleMessage(msg []byte) {
requestsMetric.Inc() requestsMetric.Inc()
} }
latencyMetric, err := sc.upstreamLatency.GetMetricWith(latencyLabels) if stats.Latency != -1 {
if err != nil { latencyMetric, err := sc.upstreamLatency.GetMetricWith(latencyLabels)
glog.Errorf("Error fetching latency metric: %v", err) if err != nil {
} else { glog.Errorf("Error fetching latency metric: %v", err)
latencyMetric.Observe(stats.Latency) } else {
latencyMetric.Observe(stats.Latency)
}
} }
if stats.RequestTime != -1 { if stats.RequestTime != -1 {