DevFW-CICD/ingress-nginx-helm
15
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Update Makefile to allow specifying tag from command line (#2092)

Browse source 
The usage text in the Makefile suggests that you can specify TAG=1.4 to your make command to build with the specified tag.  This does not work, since TAG is hard coded in the Makefile and overwrites any value you pass on the command line.

$ GOPATH=/go TAG=notagforyou make container
docker build --pull -t gcr.io/google_containers/defaultbackend-amd64:1.4 .
Sending build context to Docker daemon  5.921MB
Step 1/4 : FROM scratch
 ---> 
Step 2/4 : USER 65534:65534
 ---> Using cache
 ---> 0f38024aa24e
Step 3/4 : COPY server /
 ---> f8509ce4595d
Step 4/4 : ENTRYPOINT /server
 ---> Running in 29b31420e648
 ---> 65818e326440
Removing intermediate container 29b31420e648
Successfully built 65818e326440
Successfully tagged gcr.io/google_containers/defaultbackend-amd64:1.4

Update the TAG variable to work as documented.
This commit is contained in:
rvkubiak 2018-02-14 14:10:42 -08:00 committed by Manuel Alejandro de Brito Fontes
parent 5101e74347
commit 0311a99d3e
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
images/404-server/Makefile
View file

@ -20,7 +20,7 @@
all: push
TAG=1.4
TAG?=1.4
PREFIX?=gcr.io/google_containers/defaultbackend
ARCH?=amd64