DevFW-CICD/ingress-nginx-helm
12
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

add comment to the test

Browse source
This commit is contained in:
Elvin Efendi 2019-07-04 18:39:29 -04:00
parent 0e5913310d
commit 08906ef8f2
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
test/e2e/lua/dynamic_certificates.go
View file

@ -130,6 +130,11 @@ var _ = framework.IngressNginxDescribe("Dynamic Certificate", func() {
ensureHTTPSRequest(f.GetURL(framework.HTTPS), host, host) ensureHTTPSRequest(f.GetURL(framework.HTTPS), host, host)
}) })
/*
TODO(elvinefendi): this test currently does not work as expected
because Go transport code strips (https://github.com/golang/go/blob/431b5c69ca214ce4291f008c1ce2a50b22bc2d2d/src/crypto/tls/handshake_messages.go#L424)
trailing dot from SNI as suggest by the standard (https://tools.ietf.org/html/rfc6066#section-3).
*/
It("supports requests with domain with trailing dot", func() { It("supports requests with domain with trailing dot", func() {
ensureHTTPSRequest(f.GetURL(framework.HTTPS), host+".", host) ensureHTTPSRequest(f.GetURL(framework.HTTPS), host+".", host)
}) })