DevFW-CICD/ingress-nginx-helm
15
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix deferInLoop error (#10387)

Browse source 
Signed-off-by: z1cheng <imchench@gmail.com>
This commit is contained in:
Chen Chen 2023-09-10 21:48:10 +08:00 committed by GitHub
parent fb7f92a7d5
commit 93e006c2ce
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
internal/nginx/maxmind.go
View file

@ -179,20 +179,19 @@ func downloadDatabase(dbName string) error {
if !strings.HasSuffix(header.Name, mmdbFile) {
continue
}
return func() error {
outFile, err := os.Create(path.Join(geoIPPath, mmdbFile))
if err != nil {
return err
}
outFile, err := os.Create(path.Join(geoIPPath, mmdbFile))
if err != nil {
return err
}
defer outFile.Close()
//nolint:gocritic // TODO: will fix it on a followup PR
defer outFile.Close()
if _, err := io.CopyN(outFile, tarReader, header.Size); err != nil {
return err
}
return nil
if _, err := io.CopyN(outFile, tarReader, header.Size); err != nil {
return err
}
return nil
}()
}
}