DevFW-CICD/ingress-nginx-helm
12
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #4227 from aledbf/lint

Browse source 
Fix misspelled and e2e check
This commit is contained in:
Kubernetes Prow Robot 2019-06-24 21:30:34 -07:00 committed by GitHub
commit c8cbf0db29
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cmd/plugin/lints/deployment.go
View file

@ -58,7 +58,7 @@ func (lint DeploymentLint) Link() string {
return "" return ""
} }
// GetDeploymentLints retuns all of the lints for ingresses // GetDeploymentLints returns all of the lints for ingresses
func GetDeploymentLints() []DeploymentLint { func GetDeploymentLints() []DeploymentLint {
return []DeploymentLint{ return []DeploymentLint{
removedFlag("sort-backends", 3655, "0.22.0"), removedFlag("sort-backends", 3655, "0.22.0"),

2
cmd/plugin/lints/ingress.go
View file

@ -58,7 +58,7 @@ func (lint IngressLint) Version() string {
return lint.version return lint.version
} }
// GetIngressLints retuns all of the lints for ingresses // GetIngressLints returns all of the lints for ingresses
func GetIngressLints() []IngressLint { func GetIngressLints() []IngressLint {
return []IngressLint{ return []IngressLint{
removedAnnotation("add-base-url", 3174, "0.22.0"), removedAnnotation("add-base-url", 3174, "0.22.0"),

2
cmd/plugin/util/util.go
View file

@ -60,7 +60,7 @@ func printOrError(s string, e error) error {
return nil return nil
} }
// ParseVersionString returns the major, minor, and patch numbers of a verison string // ParseVersionString returns the major, minor, and patch numbers of a version string
func ParseVersionString(v string) (int, int, int, error) { func ParseVersionString(v string) (int, int, int, error) {
parts := versionRegex.FindStringSubmatch(v) parts := versionRegex.FindStringSubmatch(v)

2
internal/ingress/controller/store/store.go
View file

@ -57,7 +57,7 @@ import (
"k8s.io/ingress-nginx/internal/k8s" "k8s.io/ingress-nginx/internal/k8s"
) )
// IngressFilterFunc decides if an Ingress should be ommited or not // IngressFilterFunc decides if an Ingress should be omitted or not
type IngressFilterFunc func(*ingress.Ingress) bool type IngressFilterFunc func(*ingress.Ingress) bool
// Storer is the interface that wraps the required methods to gather information // Storer is the interface that wraps the required methods to gather information

1
test/e2e/dbg/main.go
View file

@ -76,6 +76,7 @@ var _ = framework.IngressNginxDescribe("Debug Tool", func() {
getCmd := "/dbg backends get " + backends[0] getCmd := "/dbg backends get " + backends[0]
output, err = f.ExecIngressPod(getCmd) output, err = f.ExecIngressPod(getCmd)
Expect(err).Should(BeNil())
var f map[string]interface{} var f map[string]interface{}
unmarshalErr := json.Unmarshal([]byte(output), &f) unmarshalErr := json.Unmarshal([]byte(output), &f)