DevFW-CICD/ingress-nginx-helm
14
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Don't reconcile health checks after first create.

Browse source
This commit is contained in:
bprashanth 2016-09-23 14:22:22 -07:00
parent d99efea804
commit e30bbdfe2c
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
controllers/gce/healthchecks/healthchecks.go
View file

@ -64,13 +64,13 @@ func (h *HealthChecks) Add(port int64) error {
return err return err
} }
} else if wantHC.RequestPath != hc.RequestPath { } else if wantHC.RequestPath != hc.RequestPath {
// TODO: also compare headers interval etc. // TODO: reconcile health checks, and compare headers interval etc.
glog.Infof("Updating health check %v, path %v -> %v", name, hc.RequestPath, wantHC.RequestPath) // Currently Ingress doesn't expose all the health check params
if err := h.cloud.UpdateHttpHealthCheck(wantHC); err != nil { // natively, so some users prefer to hand modify the check.
return err glog.Infof("Unexpected request path on health check %v, has %v want %v, NOT reconciling",
} name, hc.RequestPath, wantHC.RequestPath)
} else { } else {
glog.Infof("Health check %v already exists", hc.Name) glog.Infof("Health check %v already exists and has the expected path %v", hc.Name, hc.RequestPath)
} }
return nil return nil
} }