Small text format changes to section "I have more than one controller running in my cluster, and I want to use the new spec?" to allow for better readability.
* OWNERS_ALIASES: add ingress-nginx-kube-webhook-certgen-reviewers
For extra kube-webhook-certgen reviewers.
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
* images/kube-webhook-certgen: add separate owners
To add myself as a reviewer as discussed in #7641.
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
* priorityClassName should be in " "
Example: https://github.com/helm/charts/blob/master/stable/k8s-spot-rescheduler/templates/deployment.yaml#L28
* Update charts/ingress-nginx/templates/controller-deployment.yaml
Co-authored-by: Alex Harder <13860012+ChiefAlexander@users.noreply.github.com>
Co-authored-by: Ricardo Katz <rikatz@users.noreply.github.com>
Co-authored-by: Alex Harder <13860012+ChiefAlexander@users.noreply.github.com>
* Add support to ipFamilyPolicy and ipFamilies fields in Helm chart
As stated in the prerequisites' session of https://kubernetes.io/docs/concepts/services-networking/dual-stack/, in order to use Kubernetes IPv4/IPv6 dual stack, v1.20 is needed. This commit aims in supporting these dual-stack-ness in ingress-nginx's chart.
Signed-off-by: jaehnri <joao.henri.cr@gmail.com>
* Standardize documentation with two '#'s
Signed-off-by: jaehnri <joao.henri.cr@gmail.com>
* Bump Helm chart version to 4.1.0
Signed-off-by: jaehnri <joao.henri.cr@gmail.com>
* Update Helm Chart changelog with 4.1.0 description
Signed-off-by: jaehnri <joao.henri.cr@gmail.com>
* Revert Helm Chart bump and remove CHANGELOG
As there will be more things in the release, in the review of this PR, it was asked to revert the bumps:
https://github.com/kubernetes/ingress-nginx/pull/7651#pullrequestreview-757311449
Signed-off-by: jaehnri <joao.henri.cr@gmail.com>
* images/kube-webhook-certgen/rootfs: improve tests objects creation
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
* images/kube-webhook-certgen/rootfs: use context with deadline for tests
So in case some operations are taking more time, we respect -timeout
flag.
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
* images/kube-webhook-certgen/rootfs: add missing tests implementation
It should've been added in 9acf62d867.
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
* images/kube-webhook-certgen/rootfs: fix patching only mutating webhook
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
As a follow up to PR #7641, this commit adds some basic e2e tests for
kube-webhook-certgen image.
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Proposal to add information to Helm Installation
I can into an issue recently which cost me the better part of an afternoon and evening. The only information about some changes, I was not aware of, was in this blog post about improvements in 1.18.
The information about the errors I was receiving lead me to dead ends prior to finding that blog post. `IngressClass` and `ingressClassName` are thrown around a lot and it can be confusing but it helped me to eventually find a solution.
I kept getting `Error: rendered manifests contain a resource that already exists. Unable to continue with install: IngressClass "nginx" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata ...` and could not figure out how to fix it.
I believe adding the proposed changes, or a version of them, would help eliminate that frustration I experienced for other users that may run into these issues.
