git
69a416b84d
Please correct controller and the ship correct "span->SetStatus(trace::StatusCode...." and not "Ok" as default with all http_code. #12210
...
OPENTELEMETRY_CPP_VERSION="v1.17.0"
perl -pi -e "s/(OPENTELEMETRY_CPP_VERSION=)(.*)/\1\"$OPENTELEMETRY_CPP_VERSION\"/g;" images/nginx/rootfs/build.sh
OPENTELEMETRY_PROTO_VERSION="v1.3.2"
perl -pi -e "s/(OPENTELEMETRY_PROTO_VERSION=)(.*)/\1\"$OPENTELEMETRY_PROTO_VERSION\"/g;" images/nginx/rootfs/build.sh
OPENTELEMETRY_CONTRIB_COMMIT=f6d29426ee9b4d6b476c09ca3cb9bed3cf23906f
perl -pi -e "s/(OPENTELEMETRY_CONTRIB_COMMIT=)(.*)/\1\"$OPENTELEMETRY_CONTRIB_COMMIT\"/g;" images/nginx/rootfs/build.sh
perl -pi -e "s/(libprotobuf.*)/\1\n abseil-cpp-crc-cpu-detect \\\/g;" images/nginx/rootfs/Dockerfile
Ingress-NGINX 1.10.0 has dropped support for OpenTracing and Zipkin, favoring OpenTelemetry instead.
The OpenTelemetry module used by Ingress-NGINX is based on a old commit, and has received updates since then.
The correct value is not set according "span->SetStatus(trace::StatusCode::kError);".
Per default it's not correct set with "span->SetStatus(trace::StatusCode::kOk);" if there a trace with error (>=http_code 500).
Here is my pull request intern in my repo
according:
release 1.10: tsimonitoring/ingress-nginx#9
release 1.11: tsimonitoring/ingress-nginx#10
release 1.12: tsimonitoring/ingress-nginx#11
(in Datadog it's metric trace.nginx.server.errors.)
The changes according Ingress-NGINX 1.11.2 with my branch solved the problem according trace error status: https://github.com/tsimonitoring/ingress-nginx/tree/release-1.11.3-patch-opentelemetry-cpp-and-contrib-and-proto
As example tested on my side in Datadog.
There are correct OPENTELEMETRY_CPP_VERSION, OPENTELEMETRY_PROTO_VERSION, OPENTELEMETRY_CONTRIB_COMMIT in build.sh incl. apk upgrade abseil-cpp-crc-cpu-detect (add) in Dockerfile NGINX.
Before (https://i.imgur.com/LpvotMx.png ) there was no shipped metric according error_status per OpenTelemetry Module.
After (https://i.imgur.com/xvz6b05.png ) you can see the shipped error metric also in trace view or see diag example (https://i.imgur.com/xEEY2Ep.png ).
Please see https://github.com/tsimonitoring/ingress-nginx/tree/release-1.11.3-patch-opentelemetry-cpp-and-contrib-and-proto
Is there currently another issue associated with this?
So far as i know there is no another issue associated with this (in this repo) according the "span->SetStatus(trace::StatusCode...." .
Hint: There's a solved issue #11496 , which solved shipping the http error code.
This issue i want to solve is: "Please correct controller and the ship correct "span->SetStatus(trace::StatusCode....".
OpenTelemetry module was updated with open-telemetry/opentelemetry-cpp-contrib#443
or in detail the commit:
open-telemetry/opentelemetry-cpp-contrib@415f182#diff-ac2154f3c67fc196193c979a092240e417392a11387cb1e2ba181828238cc8ffR551 .
2024-11-15 12:30:31 +01:00
Marco Ebert
76f90ec8cf
CI: Update KIND images. ( #12364 )
2024-11-14 00:24:46 +00:00
chriss-de
698960e9b7
Config/Annotations: Add relative-redirects. ( #12161 )
2024-11-13 21:02:48 +00:00
Ricardo Katz
0207d1878a
Bump golangci-lint on actions and disable deprecated linters ( #12360 )
2024-11-13 15:38:47 +00:00
Felix Dobler
be8abe7a5c
Chart: Add service cluster IPs. ( #12333 )
2024-11-12 21:26:46 +00:00
dependabot[bot]
a37994cb52
Bump google.golang.org/grpc from 1.67.1 to 1.68.0 ( #12347 )
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-11 20:20:46 +00:00
dependabot[bot]
7596021012
Bump the actions group with 3 updates ( #12348 )
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-11 18:48:45 +00:00
dependabot[bot]
315f07ced6
Bump golang.org/x/crypto from 0.28.0 to 0.29.0 ( #12346 )
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-11 18:46:46 +00:00
Marco Ebert
79c684f9ce
Images: Bump gcb-docker-gcloud to v20241110-72bb0b1665. ( #12340 )
2024-11-11 02:22:44 +00:00
Marco Ebert
4a447782ac
Go: Bump to v1.23.3. ( #12320 )
2024-11-10 20:36:43 +00:00
Marco Ebert
7f0350b4b3
Auth TLS: Add _ to redirect RegEx. ( #12325 )
2024-11-07 20:32:44 +00:00
James Strong
ca81d5bcdd
Auth TLS: Improve redirect RegEx. ( #12249 )
2024-11-07 00:19:29 +00:00
Satyam Zode
af095e4216
Update custom headers annotation documentation ( #12317 )
...
Signed-off-by: Satyam Zode <satyamz@users.noreply.github.com>
Co-authored-by: Satyam Zode <satyamz@users.noreply.github.com>
2024-11-06 17:53:30 +00:00
Marco Ebert
b3742aa5de
Tests: Bump e2e-test-runner to v20241104-02a3933e. ( #12311 )
2024-11-05 20:53:44 +01:00
Jon Carl
0909a61ea3
Docs: Add CPU usage note for --metrics-per-undefined-host. ( #12309 )
2024-11-04 22:21:28 +00:00
Marco Ebert
02a3933ea9
Images: Trigger test-runner build. ( #12304 )
2024-11-04 20:32:03 +01:00
dependabot[bot]
4809310016
Bump github.com/fsnotify/fsnotify from 1.7.0 to 1.8.0 ( #12293 )
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-04 12:07:28 +00:00
dependabot[bot]
2984e1a2ad
Bump github.com/opencontainers/runc from 1.2.0 to 1.2.1 in the go group across 1 directory ( #12292 )
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-04 12:05:28 +00:00
dependabot[bot]
a1134bf474
Bump github.com/onsi/ginkgo/v2 from 2.20.2 to 2.21.0 ( #12271 )
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marco Ebert <marco_ebert@icloud.com>
2024-11-04 09:19:28 +00:00
Aleksa Cukovic
ac23d4069b
Config: Fix panic on invalid lua-shared-dict. ( #12281 )
2024-11-02 21:21:26 +00:00
Aleksa Cukovic
440575e151
Docs: fix limit-rate-after references ( #12277 )
2024-10-31 19:29:26 +00:00
dependabot[bot]
a8c62e22b7
Bump actions/dependency-review-action from 4.3.5 to 4.4.0 in the actions group ( #12272 )
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-29 23:05:24 +00:00
yypastushenko
260976b8d8
Chart: Implement ServiceMonitor limits. ( #12251 )
2024-10-29 22:49:25 +00:00
Marco Ebert
d0a04308c8
Chart: Rework ServiceMonitor. ( #12267 )
2024-10-29 22:45:51 +01:00
Aran Shavit
e07f0f6890
Chart: Set automountServiceAccountToken in workloads. ( #12247 )
...
Signed-off-by: Aran Shavit <Aranshavit@gmail.com>
Co-authored-by: Marco Ebert <marco_ebert@icloud.com>
2024-10-29 20:55:25 +00:00
Aran Shavit
bd76cf8f05
Chart: Add ServiceAccount tests. ( #12261 )
...
Signed-off-by: Aran Shavit <Aranshavit@gmail.com>
2024-10-29 17:46:57 +00:00
Ricardo Katz
7356c4f40f
Lua: Extract external auth into file. ( #12250 )
...
Co-authored-by: Marco Ebert <marco_ebert@icloud.com>
2024-10-29 13:22:54 +00:00
Aran Shavit
6608eb23b0
CI: Fix chart testing. ( #12257 )
...
Signed-off-by: Aran Shavit <Aranshavit@gmail.com>
Co-authored-by: Marco Ebert <marco_ebert@icloud.com>
2024-10-29 13:42:18 +01:00
Antonio Ojea
4f62e980be
Deploy: Use LoadBalancer for KIND. ( #12232 )
2024-10-29 08:00:07 +01:00
dependabot[bot]
bce6b4d73f
Bump the go group across 3 directories with 11 updates ( #12237 )
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-28 13:40:54 +00:00
dependabot[bot]
c68e208734
Bump github.com/opencontainers/runc from 1.1.15 to 1.2.0 ( #12238 )
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-28 12:54:54 +00:00
dependabot[bot]
0b90088dde
Bump the actions group with 5 updates ( #12235 )
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-28 11:04:54 +00:00
Stepan Paksashvili
dc3acbd786
[fix] fix nginx temp configs cleanup ( #11569 )
...
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
2024-10-22 16:38:53 +01:00
dependabot[bot]
c9d33b75d5
Bump github.com/ncabatoff/process-exporter from 0.8.3 to 0.8.4 in the go group across 1 directory ( #12214 )
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-21 13:39:04 +01:00
dependabot[bot]
00295d1c39
Bump aquasecurity/trivy-action from 0.27.0 to 0.28.0 in the actions group ( #12213 )
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-21 13:37:06 +01:00
m00lecule
0edf16ff6b
Chart: Suggest matchLabelKeys in Topology Spread Constraints. ( #12201 )
2024-10-16 06:09:02 +01:00
Hung Tran
1c0f4fa8b2
Docs: Add Pod Security Admission. ( #12174 )
...
Co-authored-by: Marco Ebert <marco_ebert@icloud.com>
2024-10-15 14:56:22 +01:00
Fedello
162e3932a2
Docs: Clarify external & service port in TCP/UDP services explanation. ( #12172 )
2024-10-15 14:28:21 +01:00
dependabot[bot]
8a020bd069
Bump github/codeql-action from 3.26.12 to 3.26.13 in the actions group ( #12183 )
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-15 14:06:22 +01:00
dependabot[bot]
e3d9fedfaf
Bump the go group across 2 directories with 1 update ( #12182 )
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-15 13:58:21 +01:00
dependabot[bot]
8eda255768
Bump the actions group with 2 updates ( #12169 )
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-15 12:14:22 +01:00
dependabot[bot]
d9c46275f9
Bump github.com/opencontainers/runc from 1.1.14 to 1.1.15 in the go group across 1 directory ( #12168 )
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-15 12:12:22 +01:00
Marco Ebert
8b9abd207b
Release controller v1.12.0-beta.0/v1.11.3/v1.10.5 & chart v4.12.0-beta.0/v4.11.3/v4.10.5. ( #12166 )
2024-10-15 10:48:22 +01:00
dependabot[bot]
05eda3db8b
Bump the actions group with 3 updates ( #12144 )
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-07 21:00:22 +01:00
Marco Ebert
75c77e5dc3
Metrics: Disable by default. ( #12095 )
2024-10-07 20:34:22 +01:00
Marco Ebert
c9aa724f6d
Tests & Docs: Bump e2e-test-echo to v1.0.1. ( #12143 )
2024-10-07 21:26:18 +02:00
Marco Ebert
293b4fef24
Images: Trigger e2e-test-echo build. ( #12132 )
2024-10-07 13:46:22 +01:00
Marco Ebert
fdfc97a7fb
Images: Drop s390x. ( #12131 )
2024-10-07 13:30:21 +01:00
Marco Ebert
deb01b9f2c
Images: Build s390x controller. ( #12125 )
2024-10-06 16:51:06 +02:00
Marco Ebert
657393e7b3
Chart: Bump Kube Webhook CertGen. ( #12119 )
2024-10-06 08:50:03 +01:00
