* feat(argo-workflows): Support Azure Blob Storage for artifact
Signed-off-by: yu-croco <yu.croco@gmail.com>
* chore(argo-workflows): refactor, from if/else to with
Signed-off-by: yu-croco <yu.croco@gmail.com>
Fixes#1430#1468
Due to multiple instances where new/changed CRDs for argo-workflows do not
get installed/updated I believe it is time to move the crds folder into
the templates folder like our other helm charts.
I'm aware helm 3 is supposed to handle the crds folder but it seems there
are a few known issues currently [here](https://github.com/hashicorp/terraform-provider-helm/issues/944), [here](https://github.com/helm/helm/issues/11321) and [here](https://github.com/helm/helm/pull/11330) that show that may still
need some work.
Signed-off-by: jmeridth <jmeridth@gmail.com>
Signed-off-by: jmeridth <jmeridth@gmail.com>
Standardize helm chart maintainer to be
```yaml
maintainers:
- name: argoproj
url: https://argoproj.github.io/
```
We'll use CODEOWNERS to notify individual maintainers about PRs to the helm charts and will be our source-of-truth for that information
Signed-off-by: jmeridth <jmeridth@gmail.com>
* feat(argo-workflows): Moved `.Values.images` values to global
Signed-off-by: yu-croco <yuki.kita22@gmail.com>
* Revert "feat(argo-workflows): Moved `.Values.images` values to global"
This reverts commit 67b4294675.
Signed-off-by: yu-croco <yuki.kita22@gmail.com>
* feat(argo-workflows): Add global tag
Signed-off-by: yu-croco <yuki.kita22@gmail.com>
* feat(argo-workflows): Assign common labels to controller resources
Signed-off-by: kenchan0130 <tt.tanishi100@gmail.com>
* feat(argo-workflows): Assign common labels to the server sa resource
Signed-off-by: kenchan0130 <tt.tanishi100@gmail.com>
* Update argo-workflows Chart.yaml
Signed-off-by: kenchan0130 <tt.tanishi100@gmail.com>
* fix(argo-workflows): add missing rules for workflow role to run HTTP/plugin templates
Signed-off-by: yu-croco <yuki.kita22@gmail.com>
* chore(argo-workflows): refactor role rules simpler
Signed-off-by: yu-croco <yuki.kita22@gmail.com>
* feat(argo-workflows): add support for Deployment annotations
bump version and add changelog
update documentation
Signed-off-by: snooyen <sean@bright.ai>
* Apply suggestions from code review
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* Added short tag function and updated templates
Signed-off-by: John Clark <clark.john.d@outlook.com>
* Chart.yaml update (version, changes)
Signed-off-by: John Clark <clark.john.d@outlook.com>
* Removed unnecessary conditional logic
Signed-off-by: John Clark <clark.john.d@outlook.com>
* Final newline to _helpers
Signed-off-by: John Clark <clark.john.d@outlook.com>
* Rework without template function
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* Fix typos and add missing words in README.md
No real content changes, just textual improvements.
* Bump version and add changelog
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* Sync changes README.md -> README.md.gotmpl
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* argo-workflows: update to Argo Workflows version 3.3.1
* Add WorkflowTaskResult CRD
* Add associated permissions to Workflow Controller Role
Signed-off-by: Ira W. Snyder <ira@descarteslabs.com>
* Address review comments
Signed-off-by: Ira W. Snyder <ira@descarteslabs.com>
* Update to Argo Workflows v3.3.2
A new release is out.
Signed-off-by: Ira W. Snyder <ira@descarteslabs.com>
* Add list
Signed-off-by: Frank Bagherzadeh <frankbzd@gmail.com>
* bump version and add change log
Signed-off-by: Frank Bagherzadeh <frankbzd@gmail.com>
* fix changelog
Signed-off-by: Frank Bagherzadeh <frankbzd@gmail.com>
* optional role
Signed-off-by: Carl Raiden Worley <carl.worley@10gen.com>
* match existing setting
Signed-off-by: Carl Raiden Worley <carl.worley@10gen.com>
* fix lint
Signed-off-by: Carl Raiden Worley <carl.worley@10gen.com>
* feat(argo-workflows): Add controller volumes
Signed-off-by: John Clark <clark.john.d@outlook.com>
* Chart.yaml mispelling (paramaters > parameters)
Signed-off-by: John Clark <clark.john.d@outlook.com>
* Apply suggestions from code review
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* feat(argo-workflows): argo workflows chart to allow set the namespace of Prometheus ServiceMonitor.
Signed-off-by: mugioka <okamugi0722@gmail.com>
* Bump minor chart version
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* Add missing WorkflowTasksets RBAC to controller
Signed-off-by: Paul Ayling <paulayling.dev@gmail.com>
* Add WorkflowTaskSet RBAC to admin role
Signed-off-by: Paul Ayling <paulayling.dev@gmail.com>
* feat(argo-workflows) Include pod name in key format for GCS logs
A better default would be to add the `pod.name` to the key format of the Argo logs.
I noticed that when not including the pod name, it would constantly overwrite the same log from from different pods.
Including it makes sure that each pod will have its own log file.
Signed-off-by: Michiel De Mey <de.mey.michiel@gmail.com>
* Bump chart version and added changelog
Signed-off-by: Michiel De Mey <de.mey.michiel@gmail.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* Use helm-docs for argo-workflows
Signed-off-by: Tuan Anh Tran <me@tuananh.org>
* bump version and update changelog
Signed-off-by: Tuan Anh Tran <me@tuananh.org>
* ci: add step to check if docs is staled and needs update
Signed-off-by: Tuan Anh Tran <me@tuananh.org>
* docs: run helm-docs to generate readme
Signed-off-by: Tuan Anh Tran <me@tuananh.org>
* Add missing parameter documentation
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* Add .helmdocsignore for charts which not yet use helm-docs
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* Do not exclude argocd-notifications anymore
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* feat(argo-workflows): Bump appVersion to 3.2.0
Signed-off-by: Louis Haußknecht <lh@haussknecht.com>
* feat(argo-workflows): Add WorkflowTaskSet to CRD
Signed-off-by: Louis Haußknecht <lh@haussknecht.com>
* feat(argo-workflows): Synced CRDs with https://github.com/argoproj/argo-workflows/tree/v3.2.0/manifests/base/crds/minimal.
Signed-off-by: Louis Haußknecht <lh@haussknecht.com>
* Bump Chart version
Signed-off-by: Marko Bevc <marko@scalefactory.com>
Co-authored-by: Marko Bevc <marko@scalefactory.com>
* Allow NodePort to be specified for server service.
Signed-off-by: Peter Oruba <peter@oruba.de>
* Different version number and different condition in NodePort setting evaluation, both as per PR review suggested.
Signed-off-by: Peter Oruba <peter@oruba.de>
* Allow setting the metrics port name
Here, we scrape every pod that has a .*-metrics port here
But the helm chart is locked to `metrics` which our Prometheus doesn't see
This PR will make it configurable with a default value of `metrics`
Signed-off-by: Julien Duchesne <julien.duchesne@grafana.com>
* Bump version
Signed-off-by: Julien Duchesne <julien.duchesne@grafana.com>
* Bump minor version
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* Bump appVersion to 3.1.0
Signed-off-by: Matt Carr <mcarr@kinaxis.com>
* Update charts/argo-workflows/Chart.yaml
Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: Matt Carr <mcarr@kinaxis.com>
* Fix conflicts with upstream
Signed-off-by: Matt Carr <mcarr@kinaxis.com>
* Update changelog annotations and bump minor version
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* feat: Add support for extra containers in server & controller deployment
Signed-off-by: Mike Bryant <mikebryant@bulb.co.uk>
* Update charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml
Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: Mike Bryant <mike@mikebryant.me.uk>
* Update charts/argo-workflows/templates/server/server-deployment.yaml
Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: Mike Bryant <mike@mikebryant.me.uk>
Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
* allow workflow to be run in multiple namespaces, bump chart version
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* update helm install instructions
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* fix indents
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* add newlines
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* bump chart version
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* default to "argo" namespace for workflow service account
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* simplify setting service account, fix syntactical error in defaulting to "argo" namespace
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* Bump only the chart version, revert bumping the controller version: 3.0.8 does not exist yet as a workflow-controller image version
Signed-off-by: reinvantveer <reinvantveer@gmail.com>
* don't set a namespace if there isn't one provided
Signed-off-by: reinvantveer <reinvantveer@gmail.com>
* bump version
Signed-off-by: reinvantveer <reinvantveer@gmail.com>
* re-use controller.workflowNamespaces instead of introducing workflow.namespaces
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* re-use controller.workflowNamespaces instead of introducing workflow.namespaces
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* re-use controller.workflowNamespaces instead of introducing workflow.namespaces
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* re-use controller.workflowNamespaces instead of introducing workflow.namespaces, add additional inline comments on rbac.create effect
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* compress namespaces from controller.workflowNamespaces and workflow.namespace into single loop iteration
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* compress namespaces from controller.workflowNamespaces and workflow.namespace into single loop iteration
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* compress namespaces from controller.workflowNamespaces and workflow.namespace into single loop iteration
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* dro now-redundant branch for controller.workflowNamespaces
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* use template helper "argo-workflows.fullname" instead of release name in order to be able to override the service account name
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* add missing "template" keyword
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* drop redundant $namespace assignment that was already moved inside the "range" function
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* replace "define" templates with simple values now that controller.workflowNamespaces and workflow.namespace are unified into a single "range" iteration
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* drop redundant $namespace assignment that was already moved inside the "range" function
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* inline "define" templates with simple values now that controller.workflowNamespaces and workflow.namespace are unified into a single "range" iteration
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* inline "define" templates with simple values now that controller.workflowNamespaces and workflow.namespace are unified into a single "range" iteration
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* add missing "$" to denote target for templating the workflows fullname helper
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* restore `with` blocks for service account name and service account annotations
Signed-off-by: reinvantveer <reinvantveer@gmail.com>
* drop validations: considering cases of `workflowNamespaces`, `namespace` and `singleNamespace`
Signed-off-by: reinvantveer <reinvantveer@gmail.com>
* include case for single namespaces with default ("") namespace, otherwise (ternary) combine the workflow namespace and workflowNamespaces from the controller settings into a list to iterate over
Signed-off-by: reinvantveer <reinvantveer@gmail.com>
* wrap namespace configuration in `with` block to prevent setting it to ""
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* fix append vs. concat bug: append workflowNamespace to (possibly 0-lenght) list of controller.workflowNamespaces
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
* fix namespace range with additional check for either single namespace being false, or append to the workflow namespaces: the first non-null (coalesce) from the workflow namespace or the namespace Argo is being deployed to.
Signed-off-by: reinvantveer <reinvantveer@gmail.com>
* add changelog entries
Signed-off-by: reinvantveer <reinvantveer@gmail.com>
* unwrap (inline) with-block for service account name
Signed-off-by: reinvantveer <reinvantveer@gmail.com>
Co-authored-by: Vlad Losev <vladlosev@users.noreply.github.com>
* fix(argo-workflows): Observe 'controller.serviceAccount.create'
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* chore: Ignore ci/ directory in final package
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* chore(argo-workflows): Add missing value
Signed-off-by: yu-croco <yuki.kita22@gmail.com>
* reflect review: make it shorter and clearer.
Signed-off-by: yu-croco <yuki.kita22@gmail.com>
* Apply suggestions from code review
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* Apply suggestions from code review
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* Update example for extraPaths for usage with k8s>=1.19 with "networking.k8s.io/v1"
Signed-off-by: sturman <4456572+sturman@users.noreply.github.com>
* Fix typos in values.yaml
Signed-off-by: sturman <4456572+sturman@users.noreply.github.com>
* Bump charts version
Signed-off-by: sturman <4456572+sturman@users.noreply.github.com>
* Apply suggestions from code review
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
